Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use mustCall in place of countdown in timers test #32416

Closed
wants to merge 0 commits into from
Closed

test: use mustCall in place of countdown in timers test #32416

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 22, 2020

Use common.mustCall() in place of countdown in
test-timers-immediate-unref.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 22, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 22, 2020 •
edited by Trott
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29975/ ✔️

@Trott
Copy link
Member Author

Trott commented Mar 24, 2020

Landed in 96f06e6

Trott added a commit to Trott/io.js that referenced this pull request Mar 24, 2020
@Trott
test: use mustCall in place of countdown in timers test
96f06e6 
Use common.mustCall() in place of countdown in
test-timers-immediate-unref.

PR-URL: nodejs#32416
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott closed this Mar 24, 2020
@Trott Trott deleted the timers-tests branch March 24, 2020 05:54
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: use mustCall in place of countdown in timers test
0bb524f 
Use common.mustCall() in place of countdown in
test-timers-immediate-unref.

PR-URL: #32416
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: use mustCall in place of countdown in timers test
2f73e6e 
Use common.mustCall() in place of countdown in
test-timers-immediate-unref.

PR-URL: #32416
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: use mustCall in place of countdown in timers test
7f5b89c 
Use common.mustCall() in place of countdown in
test-timers-immediate-unref.

PR-URL: #32416
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @addaleax @lpinca