Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve wording in vm.md and esm.md #32427

Merged
merged 2 commits into from
Mar 24, 2020
Merged

doc: improve wording in vm.md and esm.md #32427

merged 2 commits into from
Mar 24, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 22, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 22, 2020
addaleax
addaleax approved these changes Mar 22, 2020
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2020
devsnek
devsnek approved these changes Mar 22, 2020
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good tweet

Trott added 2 commits March 24, 2020 10:24
@Trott
doc: improve wording in esm.md
43922a5 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: nodejs#32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
doc: improve wording in vm.md
c78d3f2 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: nodejs#32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 24, 2020

Landed in f467b9b...c78d3f2

@Trott Trott merged commit c78d3f2 into nodejs:master Mar 24, 2020
@Trott Trott deleted the simply branch March 24, 2020 17:25
MylesBorins pushed a commit that referenced this pull request Mar 25, 2020
@Trott @MylesBorins
doc: improve wording in esm.md
bbea3f2 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 25, 2020
@Trott @MylesBorins
doc: improve wording in vm.md
dfcc3e8 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 25, 2020
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 3, 2020
@Trott @MylesBorins
doc: improve wording in esm.md
ef27b5a 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: nodejs#32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
@Trott @MylesBorins
doc: improve wording in esm.md
d8e17bf 
Simplify complex sentence. Remove use of "straightforward".

Backport-PR-URL: #32610
PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Apr 4, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
doc: improve wording in vm.md
3d752cd 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devsnek devsnek devsnek approved these changes

@ExE-Boss ExE-Boss ExE-Boss approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @addaleax @lpinca @ExE-Boss @devsnek @trivikr @nodejs-github-bot