Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] url: handle quasi-WHATWG URLs in urlToOptions() #32446

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] url: handle quasi-WHATWG URLs in urlToOptions() #32446

wants to merge 1 commit into from

Conversation

freewil
Copy link

@freewil freewil commented Mar 23, 2020 •
edited
Loading

Original PR: #26226
Backport-PR-URL: #32446

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@freewil freewil force-pushed the backport-26226-url-options-whatwg-fix-to-v10.x branch from 48aaa38 to 32d9e51 Compare March 23, 2020 18:41
@freewil freewil changed the title url: handle quasi-WHATWG URLs in urlToOptions() [v10.x backport] url: handle quasi-WHATWG URLs in urlToOptions() Mar 23, 2020
@freewil freewil marked this pull request as ready for review March 23, 2020 18:44
@freewil freewil mentioned this pull request Mar 23, 2020
Merged
@freewil freewil force-pushed the backport-26226-url-options-whatwg-fix-to-v10.x branch from 32d9e51 to dcf05dc Compare March 23, 2020 18:58
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30013/

@BethGriggs
Copy link
Member

This seems uncontroversial to pull into v10.20.0 (assuming green CI) - @nodejs/release PTAL

BethGriggs pushed a commit that referenced this pull request Mar 24, 2020
@cjihrig @BethGriggs
url: handle quasi-WHATWG URLs in urlToOptions()
4390674 
PR-URL: #26226
Backport-PR-URL: #32446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BethGriggs
Copy link
Member

Landed in 4390674

@BethGriggs BethGriggs closed this Mar 24, 2020
@freewil
Copy link
Author

freewil commented Mar 24, 2020

Thanks! 🙏

@freewil freewil mentioned this pull request Mar 24, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@freewil @nodejs-github-bot @BethGriggs @richardlau @cjihrig