src: avoid using elevated v8 namespaces in headers #32468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
jasnell
force-pushed
the
cleanup-elevated-namespaces
branch
from
172efbb to
54f866b
Compare
Signed-off-by: James M Snell <jasnell@gmail.com>
Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
cleanup-elevated-namespaces
branch
from
54f866b to
055c318
Compare
addaleax
approved these changes
Mar 24, 2020
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30035/ (:yellow_heart:) |
jasnell
added
the
author ready
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 23a3408...05da0bb |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
added
backport-blocked-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just had a handful of
using v8:...elevations in a couple of header files. This goes ahead and removes those.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes