Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: fixup options.method error message #32471

Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 24, 2020

Use options.method instead of just method in ERR_INVALID_ARG_TYPE

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 24, 2020
@jasnell jasnell force-pushed the fixup-error-message-http-client branch from 068e55d to 1e861a9 Compare March 24, 2020 21:35
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the fixup-error-message-http-client branch from 1e861a9 to 59bf960 Compare March 24, 2020 21:43
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 25, 2020
@addaleax
Copy link
Member

Landed in ca19d55

addaleax pushed a commit that referenced this pull request Mar 27, 2020
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax closed this Mar 27, 2020
addaleax pushed a commit that referenced this pull request Mar 30, 2020
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
Use `options.method` instead of just `method`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32471
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants