Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update WORKING_GROUPS.md to include Intl #3251

Closed
wants to merge 1 commit into from
Closed

doc: update WORKING_GROUPS.md to include Intl #3251

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 7, 2015

  • Intl was missing

Fixes: #3246

@srl295 srl295 added the doc Issues and PRs related to the documentations. label Oct 7, 2015
@silverwind
Copy link
Contributor

rubber stamp LGTM.

@jasnell
Copy link
Member

jasnell commented Oct 14, 2015

LGTM

srl295 added a commit that referenced this pull request Oct 14, 2015
@srl295 @jasnell
doc: update WORKING_GROUPS.md to include Intl
a441aa6 
* Intl was missing

Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3251
@jasnell
Copy link
Member

jasnell commented Oct 14, 2015

Landed in a441aa6

@jasnell jasnell closed this Oct 14, 2015
@rvagg rvagg mentioned this pull request Oct 21, 2015
Merged
@MylesBorins
Copy link
Contributor

consider for LTS

/cc @jasnell

@jasnell
Copy link
Member

jasnell commented Oct 24, 2015

Not a critical need for this

@srl295 srl295 deleted the update-WORKING_GROUPS branch October 24, 2015 07:59
@srl295
Copy link
Member Author

srl295 commented Oct 24, 2015

agree, not critical for LTS

.. but perhaps some such documentation should say "check the repo for the latest.." ? What if someone tried to follow a 17-and-a-half-month-old COLLABORATOR_GUIDE.md that they found in an LTS download? By 'documentation' I mean a few words at the top of the LTS version. Very low importance..

@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2015

Are docs like this even included in releases (other than built from source)? Seems like API doc changes are the important ones to backport. Files like this seem more relevant to working with the live project on GitHub.

This was referenced Oct 28, 2015
Closed
Closed
@MylesBorins
Copy link
Contributor

considering we have been landing similar doc fixes on lts I'm going to add this to lts-watch

If no one has objections within 24 hours I'll land it into v4.x-staging

srl295 added a commit that referenced this pull request Dec 4, 2015
@srl295 @rvagg
doc: update WORKING_GROUPS.md to include Intl
7d3acf1 
* Intl was missing

Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3251
@jasnell jasnell mentioned this pull request Dec 17, 2015
Closed
srl295 added a commit that referenced this pull request Dec 17, 2015
@srl295 @jasnell
doc: update WORKING_GROUPS.md to include Intl
8f0291b 
* Intl was missing

Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3251
srl295 added a commit that referenced this pull request Dec 23, 2015
@srl295 @jasnell
doc: update WORKING_GROUPS.md to include Intl
21287a3 
* Intl was missing

Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #3251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srl295 @silverwind @jasnell @MylesBorins @cjihrig