Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.0.0-alpha.3 #32533

Closed
wants to merge 2 commits into from
Closed

tools: update ESLint to 7.0.0-alpha.3 #32533

wants to merge 2 commits into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 28, 2020

Update ESLint to 7.0.0-alpha.3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 28, 2020
lpinca
lpinca approved these changes Mar 29, 2020
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30306/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30308/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30325/

@cjihrig
Copy link
Contributor Author

cjihrig commented Apr 1, 2020

The only remaining CI failure is:

ssh: Could not resolve hostname github.com: Name or service not known

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 1, 2020 •
edited by cjihrig
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/30329/ 💚

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
@cjihrig @addaleax
tools: update ESLint to 7.0.0-alpha.3
23a3408 
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax
Copy link
Member

addaleax commented Apr 2, 2020

Landed in 23a3408

@addaleax addaleax closed this Apr 2, 2020
@cjihrig cjihrig deleted the eslint branch April 2, 2020 23:28
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
@cjihrig @BethGriggs
tools: update ESLint to 7.0.0-alpha.3
db8daa3 
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
@cjihrig @targos
tools: update ESLint to 7.0.0-alpha.3
97a3e2f 
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
targos pushed a commit that referenced this pull request Apr 22, 2020
@cjihrig @targos
tools: update ESLint to 7.0.0-alpha.3
8bc53d1 
Update ESLint to 7.0.0-alpha.3

PR-URL: #32533
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @addaleax @Trott @lpinca