Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: fix crash if POLLHUP is received #32590

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! net: fix crash if POLLHUP is received
Co-Authored-By: Juan José <soyjuanarbol@gmail.com>
addaleax and juanarbol authored Apr 5, 2020
commit fed0629db05cc3478b817c693ba2a7c6421417b0
2 changes: 1 addition & 1 deletion src/stream_base.cc
Original file line number Diff line number Diff line change
@@ -524,7 +524,7 @@ void CustomBufferJSListener::OnStreamRead(ssize_t nread, const uv_buf_t& buf) {
Context::Scope context_scope(env->context());

// To deal with the case where POLLHUP is received and UV_EOF is returned, as
// libuv returns an empty buffer. (On unices only)
// libuv returns an empty buffer (on unices only).
if (nread == UV_EOF && buf.base == nullptr) {
stream->CallJSOnreadMethod(nread, Local<ArrayBuffer>());
return;