-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: mark test-http2-reset-flood flaky on bsd #32595
Closed
MylesBorins
wants to merge
1
commit into
nodejs:master
from
MylesBorins:test-http2-reset-flood-flaky
Closed
test: mark test-http2-reset-flood flaky on bsd #32595
MylesBorins
wants to merge
1
commit into
nodejs:master
from
MylesBorins:test-http2-reset-flood-flaky
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: nodejs#29802
CI: https://ci.nodejs.org/job/node-test-pull-request/30321/ (:heavy_check_mark:) |
2 tasks
richardlau
approved these changes
Apr 1, 2020
cjihrig
approved these changes
Apr 1, 2020
Fast-track? |
MylesBorins
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Apr 1, 2020
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 1, 2020
MylesBorins
added a commit
that referenced
this pull request
Apr 1, 2020
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: #29802 PR-URL: #32595 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
landed in 9d82c55 |
MylesBorins
added a commit
that referenced
this pull request
Apr 1, 2020
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: #29802 PR-URL: #32595 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: #29802 PR-URL: #32595 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: #29802 PR-URL: #32595 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
4 tasks
sam-github
added a commit
to sam-github/node
that referenced
this pull request
Apr 13, 2020
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Refs: nodejs#29802 Refs: nodejs#32595 PR-URL: nodejs#32825 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fast-track
PRs that do not need to wait for 48 hours to land.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is somewhat regularly flaky on 12.x and it appears master as
well. There appears to be an issue tracking flakes for 6+ months. Seems
reasonable to mark this to keep us from having red CI.
Refs: #29802