doc: improve line-wrapping in net.md #32671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
I guess the commit message isn't quite right. This doesn't exactly improve line-wrapping. It gets a bunch of lines under 80 chars without affecting rendering. Right now, the maximum line length lint rule is disabled for net.md, and this gets us close to being able to enable it. @nodejs/documentation @nodejs/linting |
lpinca
approved these changes
Apr 6, 2020
nschonni
approved these changes
Apr 6, 2020
tniessen
approved these changes
Apr 6, 2020
trivikr
approved these changes
Apr 6, 2020
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: nodejs#32671 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in c849f2d |
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: #32671 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: #32671 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Fix up a few instances so that lines don't xceed 80 characters. PR-URL: #32671 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up a few instances that don't need to exceed 80 characters.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes