Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: clean up arm build options #32704

Closed
wants to merge 3 commits into from
Closed

build: clean up arm build options #32704

wants to merge 3 commits into from

Commits on Apr 9, 2020

  1. build: clean up arm build options 

    * default to `-march=armv7` and `-mfpu=neon` when targeting armv7.
  Any Cortex-A capable of running V8 supports at least that.

* remove the `--arm-fpu=...` configure option. It was added to support
  Debian's armel port (armv5, for the purpose of this discussion) but
  V8 (and therefore Node.js) dropped support for armv5 in early 2016.

* remove the `--arm-float-abi=...` configure option. There should never
  be a reason to build in soft or softp mode; armv6 is the bare minimum
  nowadays and supports VFP.

Fixes: nodejs#30786
    @bnoordhuis
    bnoordhuis committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    64a4910 View commit details
    Browse the repository at this point in the history

  2. fixup! fix conditionals in zlib.gyp

    @bnoordhuis
    bnoordhuis committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    212e5f6 View commit details
    Browse the repository at this point in the history

  3. fixup! drop arm_features.[ch]

    @bnoordhuis
    bnoordhuis committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    254ac44 View commit details
    Browse the repository at this point in the history