doc: improve consistency in usage of NULL #32726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
nodejs-github-bot
added
doc
addaleax
requested changes
Apr 8, 2020
|
@addaleax thanks, I was not sure those made sense, removed and should be ready for another look. |
addaleax
approved these changes
Apr 14, 2020
addaleax
added
author ready
jasnell
reviewed
Apr 15, 2020
doc/api/n-api.md
Outdated
| @@ -12,7 +12,7 @@ Node.js itself. This API will be Application Binary Interface (ABI) stable | |||
| across versions of Node.js. It is intended to insulate Addons from | |||
| changes in the underlying JavaScript engine and allow modules | |||
| compiled for one major version to run on later major versions of Node.js without | |||
| recompilation. The [ABI Stability][] guide provides a more in-depth explanation. | |||
| recompilation. The [ABI Stability][] guide provides a mor'e in-depth explanation. | |||
There was a problem hiding this comment.
Suggested change
| recompilation. The [ABI Stability][] guide provides a mor'e in-depth explanation. | |
| recompilation. The [ABI Stability][] guide provides a more in-depth explanation. |
|
@jasnell I think I fixed that while you were commenting :) |
|
Github actions linter was good and this is doc only so landing. |
boneskull
approved these changes
Apr 16, 2020
mhdawson
added a commit
that referenced
this pull request
Apr 16, 2020
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
|
Landed in 8ce6f5f |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: nodejs#32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
- add backticks around use of NULL - convert from null to NULL where we mean NULL Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: #32726 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Christopher Hiller <boneskull@boneskull.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULL
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com
Not 100% sure about the conversion from null to NULL, depending on what people think I can back that part out. The changes to add the backticks is based on a suggestion in another PR and this fixes other places in the doc so that we are consistent.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes