Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use for-of in Readable.from #32855

Closed
wants to merge 1 commit into from
Closed

use for-of in Readable.from #32855

wants to merge 1 commit into from

Conversation

vadzim
Copy link
Contributor

@vadzim vadzim commented Apr 14, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@vadzim vadzim mentioned this pull request Apr 14, 2020
Closed
3 tasks
@vadzim vadzim force-pushed the UseForOfInReadableFrom branch 2 times, most recently from 8cee490 to 9355470 Compare April 14, 2020 22:41
@vadzim
stream: close iterator in Readable.from
125ba87 
Use for-of loop to traverse iterator and properly close it
if not all of its values are consumed.

Fixes: nodejs#32842
@vadzim vadzim closed this Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vadzim