Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path: fix comment grammar #32942

Closed
wants to merge 1 commit into from
Closed

path: fix comment grammar #32942

wants to merge 1 commit into from

Conversation

thecodrr
Copy link
Contributor

Hi, this is my first PR.

I was looking through the path.js source code and saw some grammar mistakes in one of the comments. Thought it would make a good first PR.

Checklist

@nodejs-github-bot nodejs-github-bot added the path Issues and PRs related to the path subsystem. label Apr 20, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@nodejs-github-bot
Copy link
Collaborator

addaleax pushed a commit that referenced this pull request Apr 28, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@addaleax
Copy link
Member

Landed in d0377a8 🎉

Thanks for being patient with us!

@addaleax addaleax closed this Apr 28, 2020
targos pushed a commit that referenced this pull request May 4, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request May 4, 2020
targos pushed a commit that referenced this pull request May 7, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
targos pushed a commit that referenced this pull request May 13, 2020
PR-URL: #32942
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants