net: don't throw on bytesWritten access #3305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
force-pushed
the
fix-byteswritten-access
branch
from
f0d0403 to
1a7bebe
Compare
| tls.TLSSocket.prototype.bytesWritten; | ||
| tty.ReadStream.super_.prototype.bytesWritten; | ||
| tty.ReadStream.prototype.bytesWritten; | ||
| tty.WriteStream.prototype.bytesWritten; |
There was a problem hiding this comment.
I'd check that they're strictEqual to undefined. Apart from that LGTM.
If bytesWritten is accessed before the object has been properly constructed then return undefined. Fixes: nodejs#3298
trevnorris
force-pushed
the
fix-byteswritten-access
branch
from
1a7bebe to
dc6c9f4
Compare
|
Thanks. Landed on a713024 |
|
landed in v4.x-staging in 01cb3fc. |
This was referenced Feb 20, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If bytesWritten is accessed before the object has been properly
constructed then return undefined.
Fixes: #3298
R=@bnoordhuis
CI: https://ci.nodejs.org/job/node-test-pull-request/470/