Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.1.0 proposal #33103

Merged
merged 93 commits into from
Apr 29, 2020
Merged
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
87605f0
doc: add juanarbol as collaborator
juanarbol Apr 17, 2020
fc71a85
doc: add N-API version 6 to table
mhdawson Apr 13, 2020
ca7e0a2
src: remove redundant v8::HeapSnapshot namespace
juanarbol Apr 14, 2020
22ccf2b
tools: decrease timeout in test.py
addaleax Apr 15, 2020
307e43d
src: elevate v8 namespaces
nimit95 Apr 15, 2020
b12204e
test: changed function to arrow function
nimit95 Apr 16, 2020
ccf6d3e
doc: add `tsc-agenda` to onboarding labels list
Trott Apr 13, 2020
2ab4ebc
stream: simplify Writable.end()
ronag Apr 16, 2020
7f49812
stream: inline unbuffered _write
ronag Apr 16, 2020
36a4f54
stream: close iterator in Readable.from
vadzim Apr 14, 2020
b957895
lib: remove unnecesary else block
ddazal Apr 3, 2020
03d02d7
fs: remove unnecessary else statement
JesuHrz Apr 4, 2020
f9b8988
src: remove validation of unreachable code
juanarbol Apr 13, 2020
861eb39
n-api: detect deadlocks in thread-safe function
Apr 6, 2020
a8ed8f5
doc: synch SECURITY.md with website
Trott Apr 17, 2020
a133ac1
perf_hooks: remove unnecessary assignment when name is undefined
rickyes Apr 18, 2020
baa8231
fs: extract kWriteFileMaxChunkSize constant
rickyes Apr 3, 2020
57c170c
doc: fix typo in zlib.md
chenmnkken Apr 17, 2020
68b7c80
doc: fix usage of folder and directory terms in fs.md
karan1205 Apr 18, 2020
c9ae385
test: mark test-child-process-fork-args as flaky on Windows
puzpuzpuz Apr 20, 2020
fa71073
doc: corrected ERR_SOCKET_CANNOT_SEND message
willarmiros Apr 14, 2020
4221b1c
src: fix null deref in AllocatedBuffer::clear
fowles Apr 16, 2020
f6be140
doc: fix typo in security-release-process.md
SASUKE40 Apr 19, 2020
8663fd5
module: partial doc removal of --experimental-modules
MylesBorins Apr 18, 2020
6fc4d17
http2: refactor and cleanup http2
jasnell Apr 15, 2020
3086813
tls: move getAllowUnauthorized to internal/options
jasnell Apr 18, 2020
ca5ebcf
tools: fix mkcodecache when run with ASAN
addaleax Apr 14, 2020
eaf841d
module: improve error for invalid package targets
MylesBorins Apr 17, 2020
b5b3efe
doc: add more info to v14 changelog
devsnek Apr 21, 2020
4dd3a7d
doc: set module version 83 to node 14
Flarna Apr 21, 2020
21d314e
module: exports not exported for null resolutions
guybedford Apr 14, 2020
4ef91a6
http2: wait for secureConnect before initializing
bcoe Apr 21, 2020
4c643c0
fs: update validateOffsetLengthRead in utils.js
daemon1024 Apr 17, 2020
95e897e
src: use using NewStringType
rickyes Apr 14, 2020
fa7d969
tools: remove unused code in doc generation tool
Trott Apr 18, 2020
005c2ba
doc: elevate diagnostic report to tier1
gireeshpunathil Mar 25, 2020
aec7bc7
doc: remove repeated word in modules.md
kodekage Apr 19, 2020
7647860
stream: finished should complete with read-only Duplex
ronag Apr 21, 2020
bbed1e5
deps: V8: cherry-pick e1eac1b16c96
Apr 21, 2020
180b935
stream: pipeline should only destroy un-finished streams
ronag Apr 21, 2020
7abc61f
stream: refactor Writable buffering
ronag Dec 15, 2019
1a2b3eb
stream: fix broken pipeline test
ronag Apr 23, 2020
b4ef062
test: test-async-wrap-constructor prefer forEach
dericop Apr 3, 2020
71f9023
doc: add angle brackets around implicit links
nschonni Apr 6, 2020
2bde116
doc: ignore no-literal-urls in changelogs
nschonni Apr 6, 2020
f92b398
doc: convert bare email addresses to mailto links
nschonni Apr 23, 2020
bf331b4
doc: ignore no-literal-urls in README
nschonni Apr 23, 2020
98b30b0
lib: simplify function process.emitWarning
himself65 Apr 22, 2020
30c2b0f
src: deprecate embedder APIs with replacements
addaleax Apr 14, 2020
45e188b
test: refactor events tests for invalid listeners
edsadr Apr 11, 2020
7e9f88e
doc: updated directory entry information
Apr 12, 2020
988c2fe
test: better error validations for event-capture
edsadr Apr 10, 2020
4c10b5f
stream: consistent punctuation
ronag Apr 19, 2020
bc755fc
src: fix compiler warnings in node_http2.cc
danbev Apr 23, 2020
d82c3c2
src: delete MicroTaskPolicy namespace
juanarbol Apr 14, 2020
737bd62
lib: unnecessary const assignment for class
yashLadha Apr 21, 2020
4b6aa07
inspector: only write coverage in fully bootstrapped Environments
joyeecheung Apr 21, 2020
c21f1f0
stream: removes unnecessary params
JesuHrz Apr 20, 2020
4143c74
vm: add importModuleDynamically option to compileFunction
devsnek Apr 21, 2020
44c157e
src: assignment to valid type
yashLadha Apr 16, 2020
2bb4ac4
stream: avoid drain for sync streams
ronag Apr 16, 2020
e07c4ff
stream: fix sync write perf regression
ronag Apr 23, 2020
8fad112
test: remove timers-blocking-callback
Fishrock123 Apr 15, 2020
f116825
doc: avoid tautology in README
ishaanjain1898 Apr 22, 2020
31c797c
http: doc deprecate abort and improve docs
ronag Apr 13, 2020
1af08e1
buffer,n-api: fix double ArrayBuffer::Detach() during cleanup
addaleax Apr 24, 2020
b50333e
deps: V8: backport 3f8dc4b2e5ba
ryzokuken Apr 22, 2020
323da6f
tls: add highWaterMark option for connect
rickyes Apr 11, 2020
b12f163
deps: upgrade openssl sources to 1.1.1g
hassaanp Apr 21, 2020
fad188f
deps: update archs files for OpenSSL-1.1.1g
hassaanp Apr 21, 2020
184e80a
stream: don't wait for close on legacy streams
ronag Apr 25, 2020
a534d82
doc: add documentation for transferList arg at worker threads
juanarbol Apr 16, 2020
c84d802
worker: fix process.env var empty key access
bl-ue Apr 26, 2020
d10c2c6
src: fix empty-named env var assertion failure
bl-ue Apr 18, 2020
23eda41
src: do not compare against wide characters
bl-ue Apr 19, 2020
4035cbe
cluster: removed unused addressType argument from constructor
yashLadha Apr 21, 2020
4abc45a
module: do not warn when accessing `__esModule` of unfinished exports
addaleax Apr 24, 2020
c82c084
util,readline: NFC-normalize strings before getStringWidth
addaleax Apr 25, 2020
11ea13f
test: refactor test-async-hooks-constructor
himself65 Apr 25, 2020
401ab61
doc: document major finished changes in v14
ronag Apr 25, 2020
59b64ad
src: add AsyncWrapObject constructor template factory
Qard Apr 25, 2020
8a4de2e
doc: improve release documentation
targos Apr 24, 2020
cb4d8ce
module: refactor condition
MylesBorins Apr 22, 2020
14e559d
doc: make openssl maintenance position independent
sam-github Apr 21, 2020
91e30e3
build: fix vcbuild error for missing Visual Studio
Hakerh400 Apr 4, 2020
794b879
doc: improve WHATWG url constructor code example
lirantal Apr 11, 2020
343c6ac
doc: assign missing deprecation code
richardlau Apr 27, 2020
68656cf
n-api: fix false assumption on napi_async_context structures
legendecas Apr 19, 2020
6a8e266
tools: update ESLint to 7.0.0-rc.0
himself65 Apr 25, 2020
3fed735
doc: fix LTS replaceme tags
addaleax Apr 24, 2020
56f50ae
deps: patch V8 to 8.1.307.31
targos Apr 26, 2020
ae157b8
stream: don't emit end after close
ronag Apr 26, 2020
9ffd8e7
2020-04-29, Version 14.1.0 (Current)
BethGriggs Apr 27, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
stream: fix broken pipeline test
An unfortunate overlap between two PR that by themselves pass
CI but together pass a test.

#32967 changes so that
pipeline does not wait for 'close'.

#32968 changed so that
all streams are not destroyed.

Which made one test fail when expected the stream to be
destroyed during pipeline callback.

PR-URL: #33030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
ronag authored and BethGriggs committed Apr 28, 2020
commit 1a2b3eb3a4744c2a802c3b9b7e0752e63b47099b
2 changes: 1 addition & 1 deletion test/parallel/test-stream-pipeline.js
Original file line number Diff line number Diff line change
@@ -982,7 +982,7 @@ const net = require('net');
dst.readable = false;
pipeline(src, dst, common.mustCall((err) => {
assert(!err);
assert.strictEqual(dst.destroyed, true);
assert.strictEqual(dst.destroyed, false);
}));
src.end();
}