Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: don't destroy completed request #33120

Closed
wants to merge 2 commits into from
Closed

http: don't destroy completed request #33120

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Apr 28, 2020 •
edited
Loading

Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: #32851

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag ronag added the http Issues or PRs related to the http subsystem. label Apr 28, 2020
@ronag ronag force-pushed the http-client-destroy-after-end branch from 1bab1cb to 0111fee Compare April 28, 2020 11:59
@ronag ronag mentioned this pull request Apr 28, 2020
Closed
@ronag ronag force-pushed the http-client-destroy-after-end branch from 0111fee to 302cb98 Compare April 28, 2020 12:02
@ronag ronag marked this pull request as ready for review April 28, 2020 16:37
@ronag ronag requested a review from mcollina April 28, 2020 16:40
@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

@nodejs/http @nodejs/web-server-frameworks @szmarczak

mcollina
mcollina approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

What's the semver level?

@ronag
Copy link
Member Author

ronag commented Apr 28, 2020

What's the semver level?

I would argue patch. It's kind of a bug fix.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31064/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31090/

@ronag ronag mentioned this pull request Apr 29, 2020
Open
@ronag
Copy link
Member Author

ronag commented Apr 30, 2020

@nodejs/http

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31119/

@ronag ronag requested review from lpinca and jasnell May 1, 2020 12:53
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31247/

@ronag
http: don't destroy completed request
8ff38ec 
Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: nodejs#32851
@ronag ronag force-pushed the http-client-destroy-after-end branch from f0028b4 to 8ff38ec Compare May 9, 2020 09:02
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31252/

@ronag
Copy link
Member Author

ronag commented May 9, 2020

@nodejs/http, this needs another review

@ronag ronag requested a review from mcollina May 9, 2020 10:27
@ronag ronag mentioned this pull request May 10, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this pull request May 10, 2020
@ronag
http: deprecate aborted property and event
304935f 
Refs: nodejs#33120
Refs: nodejs#33172
@ronag
Copy link
Member Author

ronag commented May 11, 2020

Landed in b04e884

ronag added a commit that referenced this pull request May 11, 2020
@ronag
http: don't destroy completed request
b04e884 
Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: #32851

PR-URL: #33120
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ronag ronag closed this May 11, 2020
@benjamingr
Copy link
Member

That's the fastest I've probably ever seen something I review get landed without it being fast-tracked :]

@ronag
Copy link
Member Author

ronag commented May 11, 2020

@benjamingr I was so happy that you reviewed this PR that I just had to land it as quickly as possible to celebrate! 🍾

codebytere pushed a commit that referenced this pull request May 11, 2020
@ronag @codebytere
http: don't destroy completed request
cc5c8e0 
Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: #32851

PR-URL: #33120
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
@Dmarch28 Dmarch28 mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@137717unity 137717unity mentioned this pull request Jun 19, 2022
Open
@baby636 baby636 mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@kissofire kissofire mentioned this pull request Jun 19, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 19, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Jun 19, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Jun 20, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 30, 2023
Open
@molllyn1 molllyn1 mentioned this pull request Jan 31, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
@baby636 baby636 mentioned this pull request Jan 31, 2023
Open
This was referenced Jan 31, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmarczak szmarczak szmarczak approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

@lpinca lpinca Awaiting requested review from lpinca

@jasnell jasnell Awaiting requested review from jasnell

@lundibundi lundibundi Awaiting requested review from lundibundi

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request.abort() still destroys the socket on a successful request
6 participants
@ronag @nodejs-github-bot @benjamingr @mcollina @szmarczak @BridgeAR