modified comment on line 132 #3315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. I don't think we should land this though. It's essentially just noise in git. |
|
Okay thanks, but just to be clear, for any future pull request, only push medium to big changes, or it's all good, but don't push comment changes? |
|
Comment changes are fine if they are meaningful (something has changed or needs to be explained differently or better). In this case, it looks like the extra couple spaces were probably intentional, and the linter isn't complaining. |
|
okay, no worries 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the comment to match the other comments in this file, this comment was two spaces out, but all the others are good.