Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: add bytesWritten test for Http2Stream #33162

Closed
wants to merge 2 commits into from
Closed

http2: add bytesWritten test for Http2Stream #33162

wants to merge 2 commits into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Apr 30, 2020 •
edited
Loading

Refs: #29829

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@rexagod
http2: add bytesWritten test for Http2Stream
b004027 
note that this is for the `Http2Server` class. I'll soon be
adding one for `Http2SecureServer` as well.

Refs: nodejs#29829
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31149/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 3, 2020
@addaleax
Copy link
Member

addaleax commented May 7, 2020

For whoever lands this: The commit message should start with test:

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31222/

addaleax pushed a commit that referenced this pull request May 9, 2020
@rexagod @addaleax
http2: add bytesWritten test for Http2Stream
1aa491a 
note that this is for the `Http2Server` class. I'll soon be
adding one for `Http2SecureServer` as well.

Refs: #29829

PR-URL: #33162
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

addaleax commented May 9, 2020

Landed in 1aa491a

@addaleax addaleax closed this May 9, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
@rexagod @codebytere
http2: add bytesWritten test for Http2Stream
41c5524 
note that this is for the `Http2Server` class. I'll soon be
adding one for `Http2SecureServer` as well.

Refs: #29829

PR-URL: #33162
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
@rexagod rexagod mentioned this pull request Jun 6, 2020
Open
32 tasks
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@rexagod @codebytere
http2: add bytesWritten test for Http2Stream
66dbaff 
note that this is for the `Http2Server` class. I'll soon be
adding one for `Http2SecureServer` as well.

Refs: #29829

PR-URL: #33162
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag left review comments

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rexagod @nodejs-github-bot @addaleax @jasnell @ronag @BridgeAR