src: fix compiler warning in async_wrap.cc #33322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
}
Refs: nodejs#32891
nodejs-github-bot
added
the
c++
|
👍 to fast-track? |
cjihrig
approved these changes
May 9, 2020
targos
approved these changes
May 9, 2020
addaleax
added a commit
that referenced
this pull request
May 9, 2020
../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
}
Refs: #32891
PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in ae34e47, thanks for the reviews! |
|
@addaleax should this be backported to |
|
@codebytere It’s not important to be backported, but I’m surprised that it doesn’t apply after #32891… I can try to take a look later |
|
@addaleax ah it looks like the linked pr has |
|
@codebytere Only in the past – if running |
|
Figured out the issue 😅applied now! |
codebytere
pushed a commit
that referenced
this pull request
May 11, 2020
../src/async_wrap.cc: In function ‘uint16_t node::ToAsyncHooksType(v8::PromiseHookType)’:
../src/async_wrap.cc:313:1: error: control reaches end of non-void function [-Werror=return-type]
}
Refs: #32891
PR-URL: #33322
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
Marking don't land as it affects code introduced in #32891. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #32891
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes