2015-10-13, Version 4.2.1 'Argon' (LTS) Release #3337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egg-
added a commit
to egg-/node-mysql
that referenced
this pull request
Oct 13, 2015
jasnell
force-pushed
the
v4.2.1-proposal
branch
from
2f39185 to
9ddb251
Compare
|
Let's land #3342 as well. |
|
@indutny I'll give 3342 a review, but doubt I'll finish before 4.2.1 needs to be released. Are those bugs critical issues, or could they wait for a week? |
|
Ok, there are still issues with #3342 that need working out so we won't land that now. Let's document the issue in Known Issues and fix in the next patch release. |
|
Let's report #3342 as a known issue: |
jasnell
force-pushed
the
v4.2.1-proposal
branch
from
9ddb251 to
659291c
Compare
|
@rvagg @indutny @Fishrock123 @trevnorris ... updated to reflect status of #3342 as a known issue. Please review. |
|
LGTM |
|
No strong opinion on #3342 |
|
LGTM |
|
Completed. |
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Oct 13, 2015
PR-URL: nodejs#56 Related: nodejs/node#3337 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
Starefossen
pushed a commit
to Starefossen/official-images
that referenced
this pull request
Oct 13, 2015
PR-URL: docker-library#1120 Related: nodejs/docker-node#56 nodejs/node#3337 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
RichardScothern
pushed a commit
to RichardScothern/official-images
that referenced
this pull request
Jun 14, 2016
PR-URL: docker-library#1120 Related: nodejs/docker-node#56 nodejs/node#3337 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>
MayaLekova
added a commit
to MayaLekova/node
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming for a quick release on Tuesday. We have two significant regressions with v4.2.0. Fixes have landed in master and v4.x. These are significant issues that affect native modules and anything using timers.
b3cbd13340] - buffer: fix assertion error in WeakCallback (Fedor Indutny) #3329c245a199a7] - lib: fix undefined timeout regression (Ryan Graham) #3331@nodejs/lts @rvagg @Fishrock123