Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix domain with abort-on-uncaught on PPC #3354

Closed
wants to merge 1 commit into from

Conversation

misterdjules
Copy link

Add SIGTRAP and the corresponding exit code to the list of signals/exit
codes that are expected when running tests that throw an uncaught error
and have --abort-on-uncaught-exception enabled.

Also refactor a bit related comments so that they better reflect what's
actually happening.

Fixes #3239.

Add SIGTRAP and the corresponding exit code to the list of signals/exit
codes that are expected when running tests that throw an uncaught error
and have --abort-on-uncaught-exception enabled.

Also refactor a bit related comments so that they better reflect what's
actually happening.

Fixes nodejs#3239.
@misterdjules
Copy link
Author

/cc @mhdawson @nodejs/collaborators

@mscdex mscdex added the domain Issues and PRs related to the domain subsystem. label Oct 14, 2015
@jbergstroem
Copy link
Member

@jbergstroem
Copy link
Member

TL;DR:

ok 184 test-domain-abort-on-uncaught.js
  ---
  duration_ms: 0.328

@cjihrig
Copy link
Contributor

cjihrig commented Oct 14, 2015

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

misterdjules pushed a commit that referenced this pull request Oct 14, 2015
Add SIGTRAP and the corresponding exit code to the list of signals/exit
codes that are expected when running tests that throw an uncaught error
and have --abort-on-uncaught-exception enabled.

Also refactor a bit related comments so that they better reflect what's
actually happening.

Fixes #3239.

PR: #3354
PR-URL: #3354
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@misterdjules
Copy link
Author

Landed in f45c315. Thank you @cjihrig and @jbergstroem.

@mhdawson
Copy link
Member

@jasnell looks like this one still needs to be landed in 4.x-staging as I still see the failures there f45c315

@jasnell
Copy link
Member

jasnell commented Oct 27, 2015

Ok. I'm using the lts-watch-4.x label to keep track of these. If you find any others that are missing, please attach the label and I'll get them pulled over either later today or tomorrow.

@mhdawson
Copy link
Member

You just beat me to it. Thanks :)

misterdjules pushed a commit that referenced this pull request Oct 28, 2015
Add SIGTRAP and the corresponding exit code to the list of signals/exit
codes that are expected when running tests that throw an uncaught error
and have --abort-on-uncaught-exception enabled.

Also refactor a bit related comments so that they better reflect what's
actually happening.

Fixes #3239.

PR: #3354
PR-URL: #3354
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@jasnell
Copy link
Member

jasnell commented Oct 28, 2015

Landed in v4.x-staging in 5222fcc

misterdjules pushed a commit that referenced this pull request Oct 29, 2015
Add SIGTRAP and the corresponding exit code to the list of signals/exit
codes that are expected when running tests that throw an uncaught error
and have --abort-on-uncaught-exception enabled.

Also refactor a bit related comments so that they better reflect what's
actually happening.

Fixes #3239.

PR: #3354
PR-URL: #3354
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@misterdjules misterdjules deleted the fix-issue-3239 branch July 24, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants