-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: port domains regression test from v0.10 #3356
Closed
misterdjules
wants to merge
1
commit into
nodejs:master
from
misterdjules:port-domains-clears-stack-test
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
test/parallel/test-domain-top-level-error-handler-clears-stack.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const domain = require('domain'); | ||
|
||
/* | ||
* Make sure that the domains stack is cleared after a top-level domain | ||
* error handler exited gracefully. | ||
*/ | ||
const d = domain.create(); | ||
|
||
d.on('error', common.mustCall(function() { | ||
process.nextTick(function() { | ||
// Scheduling a callback with process.nextTick will enter a _new_ domain, | ||
// and the callback will be called after the domain that handled the error | ||
// was exited. So there should be only one domain on the domains stack if | ||
// the domains stack was cleared properly when the domain error handler | ||
// returned. | ||
if (domain._stack.length !== 1) { | ||
// Do not use assert to perform this test: this callback runs in a | ||
// different callstack as the original process._fatalException that | ||
// handled the original error, thus throwing here would trigger another | ||
// call to process._fatalException, and so on recursively and | ||
// indefinitely. | ||
console.error('domains stack length should be 1, but instead is:', | ||
domain._stack.length); | ||
process.exit(1); | ||
} | ||
}); | ||
})); | ||
|
||
d.run(function() { | ||
throw new Error('Error from domain'); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include
common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, updated.