Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: uv_tty_init now returns EINVAL on IBM i #33629

Closed
wants to merge 1 commit into from
Closed

test: uv_tty_init now returns EINVAL on IBM i #33629

wants to merge 1 commit into from

Conversation

dmabupt
Copy link
Contributor

@dmabupt dmabupt commented May 29, 2020

Since the PR libuv/libuv#2753 has been landed, we need to revert the code change in PR #32338.

Based on the comment -- libuv/libuv#2753 (comment)

Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 29, 2020
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label May 29, 2020
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2020
@BridgeAR BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72 Compare May 31, 2020 12:18
@richardlau
Copy link
Member

Landed in 7774458.

@richardlau richardlau closed this Jun 1, 2020
richardlau pushed a commit that referenced this pull request Jun 1, 2020
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@dmabupt dmabupt deleted the ibmi_tty_ebadf branch June 3, 2020 08:19
codebytere pushed a commit that referenced this pull request Jun 18, 2020
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. ibm i Issues and PRs related to the IBM i platform. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants