Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: fix async-resource benchmark #33642

Closed

Commits on May 29, 2020

  1. benchmark: fix async-resource benchmark

    In the benchmark, because it performs asynchronous operations before
    writing its HTTP replies, the underlying socket can be closed by the
    peer before the response is written. Since 28e6626, that means
    that attempting to `.end()` the HTTP response results in an uncaught
    exception, breaking the benchmark.
    
    Fix that by checking whether the response object has been destroyed
    or not before attempting to call `.end()`.
    
    nodejs#33591
    addaleax committed May 29, 2020
    Configuration menu
    Copy the full SHA
    73d01d8 View commit details
    Browse the repository at this point in the history