Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: improve listeners() performance #33863

Closed
wants to merge 1 commit into from
Closed

events: improve listeners() performance #33863

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jun 13, 2020

Benchmark results (keep in mind listeners is always implicitly multiplied by 2 by the benchmark):

                                                             confidence improvement accuracy (*)   (**)  (***)
 events/ee-listeners.js raw='false' listeners=1 n=5000000                  -0.96 %       ±2.89% ±3.85% ±5.03%
 events/ee-listeners.js raw='false' listeners=10 n=5000000         ***      7.71 %       ±1.48% ±1.98% ±2.61%
 events/ee-listeners.js raw='false' listeners=100 n=5000000        ***     35.04 %       ±0.89% ±1.19% ±1.58%
 events/ee-listeners.js raw='false' listeners=2 n=5000000          ***     20.62 %       ±1.41% ±1.89% ±2.47%
 events/ee-listeners.js raw='false' listeners=5 n=5000000          ***     27.57 %       ±0.80% ±1.07% ±1.40%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js. labels Jun 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31853/

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31893/

jasnell pushed a commit that referenced this pull request Jun 17, 2020
@mscdex @jasnell
events: improve listeners() performance
a4f3206 
PR-URL: #33863
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 17, 2020

Landed in a4f3206

@jasnell jasnell closed this Jun 17, 2020
@github-actions github-actions bot mentioned this pull request Jun 18, 2020
Open
18 tasks
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@mscdex @codebytere
events: improve listeners() performance
667195e 
PR-URL: #33863
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 19, 2020
Open
36 tasks
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@mscdex @codebytere
events: improve listeners() performance
7cbbd8f 
PR-URL: #33863
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@mscdex @addaleax
events: improve listeners() performance
ff7fbc3 
PR-URL: #33863
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@Flarna Flarna Flarna approved these changes

@MrHeer MrHeer MrHeer approved these changes

@ronag ronag ronag approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mscdex @nodejs-github-bot @jasnell @addaleax @lpinca @ronag @MrHeer @Flarna @ZYSzys