-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: move sam-github to TSC Emeriti #34095
Conversation
I don't have enough time to remain active in the TSC, so I will step down.
8678b52
to
44a1f74
Compare
This moves you not just to TSC Emeritus but also to Collaborator Emeritus. Is that intentional? Or did you just intend TSC Emeritus? Sorry to see you go and hope to see you back some time when you have more cycles for Node.js. Thanks for all the work on security and everything else. And thanks for being a thoughtful collaborator. |
I don't have enough time to remain active in the TSC, so I will step down. PR-URL: #34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in 1aa847f Thanks you all. And yes, I did want to get removed from collaborators, mostly so at-nodejs/collaborators doesn't ping me :-). If I ever want to PR anything, I still can. |
I removed myself from the nodejs and nodejs-private orgs, which should hopefully clean up all my team memberships immediately, so no one has to do that manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since this only changes the README.m green linter github action is enough, landing. Sam thanks for all of the hard work over the years |
It's already landed. Going through the offboarding checklist right now. |
Sam needs to be removed from the HackerOne Node.js team. Who can do that? /ping @mcollina |
ah, just figured that out was confused since it was still open. |
@Trott I think anybody on the TSC can remove him from hacker one |
I cannot view the page to remove people from HackerOne. |
Still needs to be removed from HackerOne (unless someone already took care of it). I can't attend today's TSC meeting but maybe the HackerOne thing can be sorted out there. Everything else in the offboarding checklist for TSC has been taken care of. I'll close this, and deal with the Collaborators checklist too. |
I don't have enough time to remain active in the TSC, so I will step down. PR-URL: #34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
I don't have enough time to remain active in the TSC, so I will step down. PR-URL: #34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
I don't have enough time to remain active in the TSC, so I will step down. PR-URL: #34095 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
I don't have enough time to remain active in the TSC, so I will step down.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes