doc: clarify O_EXCL text in fs.md #34096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
PR-URL: nodejs#34045 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Edit for clarity, correct tense, and brevity. PR-URL: nodejs#34064 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
@nodejs/documentation |
Use shorter and more direct phrasing. PR-URL: nodejs#34063 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
PR-URL: nodejs#34072 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: nodejs#34046 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#34060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
approved these changes
Jun 29, 2020
Trott
added
the
author ready
|
@nodejs/fs |
Notable changes: - deps: V8: backport fb26d0bb1835 (Matheus Marchini) [nodejs#33573](nodejs#33573) - src: use symbol to store `AsyncWrap` resource (Anna Henningsen) [nodejs#31745](nodejs#31745) PR-URL: nodejs#34077
Fixes `SyntaxError: Missing parentheses in call to 'print'.` error when `python` resolves to Python 3. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#34071 Refs: nodejs#29298 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#34086 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: nodejs#34087 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. PR-URL: nodejs#34102 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
bufferSize should only look at writableLength otherwise it will always show more than what is actually pending. PR-URL: nodejs#34088 Refs: nodejs#34078 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: nodejs#34088 Refs: nodejs#34078 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Notable changes: build: * (SEMVER-MINOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#33376 cli: * (SEMVER-MINOR) add alias for report-directory to make it consistent (AshCripps) nodejs#33587 crypto: * (SEMVER-MINOR) allow KeyObjects in postMessage (Tobias Nießen) nodejs#33360 deps: * (SEMVER-MINOR) V8: cherry-pick 0d6debcc5f08 (Michaël Zasso) nodejs#33376 * (SEMVER-MINOR) update V8 to 8.3.110.9 (Michaël Zasso) nodejs#33376 dgram: * (SEMVER-MINOR) allow typed arrays in .send() (Sarat Addepalli) nodejs#22413 events: * (SEMVER-MINOR) initial implementation of experimental EventTarget (James M Snell) nodejs#33556 fs: * (SEMVER-MINOR) implement lutimes (Maël Nison) nodejs#33399 http: * (SEMVER-MINOR) expose host and protocol on ClientRequest (wenningplus) nodejs#33803 * (SEMVER-MINOR) add maxTotalSockets to agent class (rickyes) nodejs#33617 * (SEMVER-MINOR) return this from OutgoingMessage#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) return this from ClientRequest#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) return this from IncomingMessage#destroy() (Colin Ihrig) nodejs#32789 * (SEMVER-MINOR) added scheduling option to http agent (delvedor) nodejs#33278 http2: * (SEMVER-MINOR) return this for Http2ServerRequest#setTimeout (Pranshu Srivastava) nodejs#33994 * (SEMVER-MINOR) do not modify explicity set date headers (Pranshu Srivastava) nodejs#33160 process: * (SEMVER-MINOR) add unhandled-rejection throw and warn-with-error-code (Dan Fabulich) nodejs#33475 src: * (SEMVER-MINOR) store key data in separate class (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) add NativeKeyObject base class (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) rename internal key handles to KeyObjectHandle (Tobias Nießen) nodejs#33360 * (SEMVER-MINOR) add equality operators for BaseObjectPtr (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) introduce BaseObject base FunctionTemplate (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) add public APIs to manage v8::TracingController (Anna Henningsen) nodejs#33850 stream*: * runtime deprecate Transform._transformState (Robert Nagy) nodejs#32763 win: * (SEMVER-MINOR) allow skipping the supported platform check (João Reis) nodejs#33176 worker: * (SEMVER-MINOR) add public method for marking objects as untransferable (Anna Henningsen) nodejs#33979 * (SEMVER-MINOR) emit `'messagerror'` events for failed deserialization (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow passing JS wrapper objects via postMessage (Anna Henningsen) nodejs#33772 * (SEMVER-MINOR) allow transferring/cloning generic BaseObjects (Anna Henningsen) nodejs#33772 worker,fs: * (SEMVER-MINOR) make FileHandle transferable (Anna Henningsen) nodejs#33772 zlib: * (SEMVER-MINOR) add `maxOutputLength` option (unknown) nodejs#33516 PR-URL: nodejs#34093
the CODEOWNERS rules for QUIC are not working and it's not entirely clear why. Hoping it's just the way the paths were specified. PR-URL: nodejs#34147 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
Ignore subsequent calls to set_final_size unless the new size is more than the previous, in which case, we have us a bug. PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
Use a single callback function for both PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
They introduce a significant performance bottleneck at the moment. PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: nodejs#34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
|
@nodejs/collaborators Needs a second review. |
ryzokuken
approved these changes
Jul 1, 2020
Replace "is considered 'special'" with "represents a device". The latter is more clear and is derived from the stat() man page. The former is also derived from the man page, but is ambiguous because: * "considered" introduces doubt. Is it, or isn't it? * "special" is never defined. "represents a device" communicates more meaning. * "special" is in scare-quotes, introducing more doubt as to what exactly it means. Refs: https://man7.org/linux/man-pages/man2/fstat.2.html PR-URL: nodejs#34094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
PR-URL: nodejs#34096 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
|
Landed in 8ff8c68 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #34096 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes