stream: don't read when paused

[ronag]

Readable should not read when paused. Noticed while working
on further streamifying net with _construct.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

@nodejs/streams

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32134/

[lpinca]

What happens if there is buffered data and the stream is destroyed after pause? Is it possible to read the buffered data?

It seems this does not touch Readable.prototype.read() so it should still work, just want to be sure as a lot changed on streams and I did not follow everything closely.

[ronag]

What happens if there is buffered data and the stream is destroyed after pause? Is it possible to read the buffered data?

I'm not sure I follow the question. maybeReadMore is only invoked when pushing more chunks, which I don't think you can do after destroying the stream. So I don't think it's relevant in the context you are referring to.

just want to be sure as a lot changed on streams and I did not follow everything closely.

Yea, I can't say I'm an expert on the readable side of things either.

[ronag]

There is something really weird going on here with js_stream_socket in relation to the original commit in this PR.

[ronag]

Another problem here is that pipeOnDrain (not sure if related) doesn't call resume but instead does flowing =true, even though pipe uses pause().

This is quite a rabbit hole. I won't be able to sleep if I continue digging 😨.

[ronag]

I think it's best to leave this in its current and simplest form.

There are a lot of issues here that need to be resolved to fix this properly. A bit overwhelming at the moment.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32136/

[ronag]

Even simplest form fails. Closing this for now.