doc: fix entry for napi_create_external_buffer
#34125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: nodejs#33471
nodejs-github-bot
added
doc
addaleax
approved these changes
Jun 29, 2020
mafintosh
approved these changes
Jun 30, 2020
himself65
approved these changes
Jun 30, 2020
legendecas
approved these changes
Jul 3, 2020
|
Doc only change, github actions linter jobs are good landing. |
jasnell
approved these changes
Jul 3, 2020
jasnell
pushed a commit
that referenced
this pull request
Jul 3, 2020
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: #33471 PR-URL: #34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in cfa3d8f |
|
That's why I had trouble landing :) |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: #33471 PR-URL: #34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: #33471 PR-URL: #34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Remove text regarding copying, because `napi_create_external_buffer` does not copy. Fixes: #33471 PR-URL: #34125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove text regarding copying, because
napi_create_external_bufferdoes not copy.
Fixes: #33471
Checklist