Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v12.x backport] tools: enable no-else-return lint rule #34275

Closed
wants to merge 1 commit into from
Closed

[v12.x backport] tools: enable no-else-return lint rule #34275

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 9, 2020 •
edited by codebytere
Loading

Refs: #32644
Refs: #32662

PR-URL: #32667
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Jul 9, 2020
@lpinca
tools: enable no-else-return lint rule
441e6d9 
Refs: nodejs#32644
Refs: nodejs#32662

PR-URL: nodejs#32667
Backport-PR-URL: nodejs#34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca lpinca force-pushed the backport-32667-to-v12.x branch from c17687e to 441e6d9 Compare July 9, 2020 11:17
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32263/

@codebytere
Copy link
Member

@nodejs/releasers would someone mind taking a second look so i don't need to wait another 90hrs to land?

@codebytere
Copy link
Member

Landed in a131c72

@codebytere codebytere closed this Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 13, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
a131c72 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@lpinca lpinca deleted the backport-32667-to-v12.x branch July 13, 2020 18:10
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@lpinca @codebytere
tools: enable no-else-return lint rule
248f9af 
Refs: #32644
Refs: #32662

PR-URL: #32667
Backport-PR-URL: #34275
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @codebytere @targos