Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test-child-process-emfile #3430

Closed
wants to merge 5 commits into from
Closed

Fix flaky test-child-process-emfile #3430

wants to merge 5 commits into from

Commits on Oct 20, 2015

  1. test: fix flaky test-child-process-emfile 

    Require the test setup to obtain an EMFILE error and not ENFILE as
ENFILE means there is a race condition with other processes that may
close files before `spawn()` is called by the test.

Fixes: nodejs#2666
    @Trott
    Trott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    421b571 View commit details
    Browse the repository at this point in the history

  2. fixup

    @Trott
    Trott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    30edd30 View commit details
    Browse the repository at this point in the history

  3. fixup: handle unlimited being coerced to NaN

    @Trott
    Trott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    5556196 View commit details
    Browse the repository at this point in the history

  4. fixup: set with -n, check with -Hn

    @Trott
    Trott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    1a6d2e6 View commit details
    Browse the repository at this point in the history

  5. fixup: add quotes around paths

    @Trott
    Trott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    5f5bb36 View commit details
    Browse the repository at this point in the history