Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: make kill to be just process.kill #34312

Merged
merged 13 commits into from
Feb 4, 2022
Merged

cluster: make kill to be just process.kill #34312

merged 13 commits into from
Feb 4, 2022

Commits on Feb 4, 2022

  1. cluster: make kill to be just process.kill

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    b0c41ed View commit details
    Browse the repository at this point in the history

  2. cluster: make kill to be just process.kill 

    Make `Worker.prototype.kill` to be just process.kill without preforming graceful disconnect beforehand.
Refs: nodejs#33715
    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    4fb861a View commit details
    Browse the repository at this point in the history

  3. Remove from README

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    fba0315 View commit details
    Browse the repository at this point in the history

  4. Improve test-cluster-worker-kill-signal readbility

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    c1dc038 View commit details
    Browse the repository at this point in the history

  5. Addressing @mscdex comments

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    60d10ca View commit details
    Browse the repository at this point in the history

  6. Moved the assertion to the when the cluster is exiting

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    13902f2 View commit details
    Browse the repository at this point in the history

  7. Adding numberOfWorkers assertion

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    9af5aca View commit details
    Browse the repository at this point in the history

  8. Addressing @bnoordhuis comments

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    84b8cf0 View commit details
    Browse the repository at this point in the history

  9. Make the assersion in the test and not in the end 

    as suggested by @bnoordhuis
    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    7de8040 View commit details
    Browse the repository at this point in the history

  10. Align terminology

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    7f93807 View commit details
    Browse the repository at this point in the history

  11. Fix markdown lint

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    616a414 View commit details
    Browse the repository at this point in the history

  12. Re-fix markdown lint

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    080d8d4 View commit details
    Browse the repository at this point in the history

  13. Revert README.md

    Bar Admoni committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    99b7db7 View commit details
    Browse the repository at this point in the history