Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: remove setMaxSendFragment guards #34323

Closed

Conversation

tniessen
Copy link
Member

BoringSSL implements SSL_set_max_send_fragment as a function, while OpenSSL implements it as a macro. I can't test it right now, but I suspect that calling setMaxSendFragment in Electron throws (maybe @codebytere can confirm?). AFAICT, all current OpenSSL versions have the macro, so removing these guards should not break anything. (Unless we still support 1.0.2, even though it is at EOL?)

Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen added tls Issues and PRs related to the tls subsystem. openssl Issues and PRs related to the OpenSSL dependency. embedding Issues and PRs related to embedding Node.js in another project. labels Jul 12, 2020
@tniessen tniessen requested a review from codebytere July 12, 2020 13:28
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Jul 12, 2020
@tniessen tniessen removed the crypto Issues and PRs related to the crypto subsystem. label Jul 12, 2020
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we still support 1.0.2, even though it is at EOL?

We don't so no problem there.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 17, 2020
tniessen added a commit that referenced this pull request Jul 19, 2020
Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

PR-URL: #34323
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen
Copy link
Member Author

Landed in e3f8dc1, thank you for reviewing.

@tniessen tniessen closed this Jul 19, 2020
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 19, 2020
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

PR-URL: #34323
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

PR-URL: #34323
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

PR-URL: #34323
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Refs: nodejs/node-v0.x-archive#6900
Refs: nodejs/node-v0.x-archive#6889

PR-URL: #34323
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. embedding Issues and PRs related to embedding Node.js in another project. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants