Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] deps: update V8 to 8.4 #34356

Closed
wants to merge 21 commits into from
Closed

Commits on Jul 16, 2020

  1. deps: update V8 to 8.4.371.19

    targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    101a4e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d0a3a41 View commit details
    Browse the repository at this point in the history
  3. deps: V8: un-cherry-pick bd019bd

    Original commit message:
    
        [testrunner] delete ancient junit compatible format support
    
        Testrunner has ancient support for JUnit compatible XML output.
    
        This CL removes this old feature.
    
        R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
        CC=​machenbach@chromium.org
    
        Bug: v8:8728
        Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
        Reviewed-on: https://chromium-review.googlesource.com/c/1430065
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
        Commit-Queue: Tamer Tas <tmrts@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#59045}
    
    Refs: v8/v8@bd019bd
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    8be298d View commit details
    Browse the repository at this point in the history
  4. deps: patch V8 to run on older XCode versions

    Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
    property, which is a fairly new C++ feature, since that requires a newer
    XCode version than the minimum requirement in BUILDING.md and thus
    breaks CI.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    ryzokuken authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    332374e View commit details
    Browse the repository at this point in the history
  5. deps: V8: patch register-arm64.h

    Fixes a compilation issue on some platforms
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    dc9a411 View commit details
    Browse the repository at this point in the history
  6. deps: V8: forward declaration of Rtl*FunctionTable

    This should be semver-patch since actual invocation is version
    conditional.
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    refack authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    b27fe7e View commit details
    Browse the repository at this point in the history
  7. deps: make v8.h compatible with VS2015

    There is a bug in the most recent version of VS2015 that affects v8.h
    and therefore prevents compilation of addons.
    
    Refs: https://stackoverflow.com/q/38378693
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    joaocgreis authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    f997e43 View commit details
    Browse the repository at this point in the history
  8. deps: V8: silence irrelevant warnings

    PR-URL: nodejs#26685
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Refael Ackermann <refack@gmail.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    183e0ae View commit details
    Browse the repository at this point in the history
  9. deps: patch V8 to run on Xcode 8

    Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type
    passed to template call of `OwnedVector::Of`. Xcode 8 can't convert
    'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when
    returning from a function (which is likely a bug on Xcode, considering
    this worked on the prior version of Xcode as well as newer versions).
    This workaround shouldn't affect the application, since the const
    qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_.
    
    There's also a V8 test passing a const-qualified type to ::Of, but since
    we don't test V8 on Xcode 8, it should be fine to leave it as is.
    
    Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
    
    PR-URL: nodejs#32116
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    mmarchini authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    722f765 View commit details
    Browse the repository at this point in the history
  10. deps: V8: cherry-pick 9868b2aefa1a

    Original commit message:
    
        Fix SmartOS compilation errors
    
        This commit resolves compilation errors on SmartOS that
        were found while upgrading Node.js.
    
        See: nodejs#32831
        Change-Id: Ia2a2e028ba4f5bfd69c050cab4fb4e13af5eefd9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2191054
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#67793}
    
    Refs: v8/v8@9868b2a
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    65af1a7 View commit details
    Browse the repository at this point in the history
  11. deps: V8: fix compilation on VS2017

    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    gengjiawen authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    43c1e9f View commit details
    Browse the repository at this point in the history
  12. deps: V8: backport 22014de00115

    Original commit message:
    
        Reland "[snapshot] rehash JSMap and JSSet during deserialization"
    
        This is a reland of 8374feed55a5b3010f2e9593560a2d84f9f6725f.
    
        Fixed rehashing of global proxy keys by creating its identity hash
        early, before the deserialization of the context snapshot.
    
        Original change's description:
        > [snapshot] rehash JSMap and JSSet during deserialization
        >
        > To rehash JSMap and JSSet, we simply replace the backing store
        > with a new one created with the new hash.
        >
        > Bug: v8:9187
        > Change-Id: I90c25b18b33b7bc2b6ffe1b89fe17aa5f978b517
        > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2143983
        > Commit-Queue: Joyee Cheung <joyee@igalia.com>
        > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        > Cr-Commit-Position: refs/heads/master@{#67663}
    
        Bug: v8:9187, v8:10523
        Change-Id: I7a0319b1d10ff07644de902fec43e7c2b1dd8da9
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2212085
        Reviewed-by: Leszek Swirski <leszeks@chromium.org>
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Jakob Gruber <jgruber@chromium.org>
        Commit-Queue: Joyee Cheung <joyee@igalia.com>
        Cr-Commit-Position: refs/heads/master@{#67999}
    
    Refs: v8/v8@22014de
    
    PR-URL: nodejs#33300
    Refs: v8/v8@ea0719b
    Refs: v8/v8@bb9f0c2
    Refs: nodejs#17058
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    joyeecheung authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    b949068 View commit details
    Browse the repository at this point in the history
  13. deps: V8: cherry-pick eec10a2fd8fa

    Original commit message:
    
        [promisehook] Add before/after hooks to thenable tasks
    
        This will allow Node.js to properly track async context in thenables.
    
        Change-Id: If441423789a78307a57ad7e645daabf551cddb57
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215624
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
        Commit-Queue: Gus Caplan <me@gus.host>
        Cr-Commit-Position: refs/heads/master@{#68207}
    
    Refs: v8/v8@eec10a2
    
    PR-URL: nodejs#33778
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Qard authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    4ab20df View commit details
    Browse the repository at this point in the history
  14. deps: update V8 postmortem metadata script

    This commit updates V8's gen-postmortem-metadata.py script
    to fix SmartOS compilation for V8 8.4.
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    cjihrig authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    64dcfc7 View commit details
    Browse the repository at this point in the history
  15. tools: update V8 gypfiles for 8.4

    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    ryzokuken authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    da92783 View commit details
    Browse the repository at this point in the history
  16. deps: bump minimum icu version to 67

    Bump minimum version of ICU needed to build node to 67.
    
    Refs: v8/v8@611e412
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    6dec877 View commit details
    Browse the repository at this point in the history
  17. test: remove test/v8-updates/test-postmortem-metadata.js

    The postmortem metadata test is no longer used to maintain
    postmortem debugging tools. Since it frequently breaks on
    V8 updates, it makes more sense to just remove it.
    
    PR-URL: nodejs#33579
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Shelley Vohr <codebytere@gmail.com>
    cjihrig authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    dd1f4e7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2362639 View commit details
    Browse the repository at this point in the history
  19. deps: V8: re-add dummy Isolate::CheckMemoryPressure

    Undoes the ABI-breaking part of v8/v8@92a44876bd66aa.
    
    Refs: v8/v8@92a4487
    addaleax authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    c940cb7 View commit details
    Browse the repository at this point in the history
  20. deps: V8: revert de4c0042cbe6 from upstream V8

    Original commit message:
    
        [weakrefs] Remove deprecated FinalizationGroup V8 API
    
        Bug: v8:8179
        Change-Id: I16170a197028beb35309b15613004b29a956896c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2171696
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
        Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
        Auto-Submit: Shu-yu Guo <syg@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#67492}
    
    Refs: v8/v8@de4c004
    addaleax authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    4fcd9c2 View commit details
    Browse the repository at this point in the history
  21. deps: V8: update headers for ABI compatibility

    Remove new functionality that interferes with ABI compatibility.
    addaleax authored and targos committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    9ff6a3b View commit details
    Browse the repository at this point in the history