v14.6.0 proposal

.github/CODEOWNERS

@@ -59,12 +59,12 @@
 
 # quic
 
-./deps/ngtcp2/* @nodejs/quic
-./deps/nghttp3/* @nodejs/quic
-./doc/api/quic.md @nodejs/quic
-./lib/internal/quic/* @nodejs/quic
-./src/node_bob* @nodejs/quic
-./src/quic/* @nodejs/quic
+/deps/ngtcp2/ @nodejs/quic
+/deps/nghttp3/ @nodejs/quic
+/doc/api/quic.md @nodejs/quic
+/lib/internal/quic/ @nodejs/quic
+/src/node_bob* @nodejs/quic
+/src/quic/ @nodejs/quic
 
 # modules
 
@@ -74,3 +74,10 @@
 # ./lib/internal/modules/* @nodejs/modules
 # ./lib/internal/bootstrap/loaders.js @nodejs/modules
 # ./src/module_wrap* @nodejs/modules @nodejs/vm
+
+# N-API
+
+# /src/node_api* @nodejs/n-api
+# /src/js_native_api* @nodejs/n-api
+# /doc/guides/adding-new-napi-api.md @nodejs/n-api
+# /doc/api/n-api.md @nodejs/n-api

.github/ISSUE_TEMPLATE/3-api-ref-docs-problem.md

@@ -7,48 +7,71 @@ labels: doc
 
 # 📗 API Reference Docs Problem
 
-<!------------------------------------------------------------------------------
+<!--
+
 Thank you for wanting to make nodejs.org better!
 
-This template is for issues with the Node.js API reference docs.
+This template is for issues with the Node.js API
+reference documentation.
 
-For more general support, please open an issue in
-our help repo at “https://github.com/nodejs/help”.
+For problems with nodejs.org beyond the API
+reference documentation, please open an issue
+using the issue tracker for our site repository.
 
-For the issue title, enter a one-line summary after “doc: ”.
-The “✍️” signifies a request for input. If unsure, do the best you can.
+  https://github.com/nodejs/nodejs.org
 
-If you found a problem with nodejs.org beyond the API reference docs, please
-open an issue in our website repo at “https://github.com/nodejs/nodejs.org”.
-------------------------------------------------------------------------------->
+For more general support, please open an issue
+using the issue tracker for our help repository.
+
+  https://github.com/nodejs/help
+
+---
+
+For the issue title, please enter a one-line
+summary after “doc: ” (preferably 50 characters
+or less and no more than 72).
+
+The “✍️” are placeholders signifying requests for
+input. Replace them with your responses.
+
+If you are unsure of something, do your best.
 
-<!--
-Version: output of “node -v”
-Platform: output of “uname -a” (UNIX), or version and 32 or 64-bit (Windows)
-Subsystem: if known, please specify affected core module name
 -->
 
+<!-- The output of “node --version”. -->
+
 - **Version**: ✍️
+
+<!-- The output of “uname -a” (UNIX) or version
+and 32-bit or 64-bit (Windows). -->
+
 - **Platform**: ✍️
+
+<!-- The name of affected core module. -->
+
 - **Subsystem**: ✍️
 
 ## Location
 
 _Section of the site where the content exists_
 
 Affected URL(s):
+
 - https://nodejs.org/api/✍️
 
-## Problem description
+## Description
 
-_Concise explanation of what you found to be problematic_
+_Concise explanation of the problem_
 
-<!-- If applicable, include any screenshots that may help solve the problem. -->
+<!-- If applicable, include any screenshots that
+may help solve the problem. -->
 
 ✍️
 
 ---
 
-<!-- Use “[x]” to check the box below if interested in contributing. -->
+<!-- Use “[x]” to check the box below if you are
+interested in contributing. -->
 
-- [ ] I would like to work on this issue and submit a pull request.
+- [ ] I would like to work on this issue and
+      submit a pull request.

.github/workflows/build-tarball.yml

@@ -72,10 +72,10 @@ jobs:
         run: |
           git config --global core.autocrlf true
       - uses: actions/checkout@v2
-      - name: Set up Python 2.7
-        uses: actions/setup-python@v1
+      - name: Set up Python 3.8
+        uses: actions/setup-python@v2
         with:
-          python-version: 2.7
+          python-version: 3.8
       - name: Environment Information
         run: npx envinfo
       - name: Download tarball

BUILDING.md

@@ -526,7 +526,7 @@ to run it again before invoking `make -j4`.
 
 ##### Option 1: Manual install
 
-* [Python 2.7](https://www.python.org/downloads/)
+* [Python 3.8](https://www.python.org/downloads/)
 * The "Desktop development with C++" workload from
   [Visual Studio 2017 or 2019](https://visualstudio.microsoft.com/downloads/) or
   the "Visual C++ build tools" workload from the

CHANGELOG.md

@@ -31,7 +31,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V14.md#14.6.0">14.6.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V14.md#14.5.0">14.5.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.4.0">14.4.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.3.0">14.3.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V14.md#14.2.0">14.2.0</a><br/>

Makefile

@@ -1243,8 +1243,9 @@ lint-js:
 jslint: lint-js
 	@echo "Please use lint-js instead of jslint"
 
-run-lint-js-ci = tools/lint-js.js $(PARALLEL_ARGS) -f tap -o test-eslint.tap \
-		$(LINT_JS_TARGETS)
+run-lint-js-ci = tools/node_modules/eslint/bin/eslint.js \
+  --report-unused-disable-directives --ext=.js,.mjs,.md -f tap \
+	-o test-eslint.tap $(LINT_JS_TARGETS)
 
 .PHONY: lint-js-ci
 # On the CI the output is emitted in the TAP format.

README.md

@@ -187,8 +187,6 @@ For information about the governance of the Node.js project, see
 **Matheus Marchini** <mat@mmarchini.me>
 * [MylesBorins](https://github.com/MylesBorins) -
 **Myles Borins** <myles.borins@gmail.com> (he/him)
-* [sam-github](https://github.com/sam-github) -
-**Sam Roberts** <vieuxtech@gmail.com>
 * [targos](https://github.com/targos) -
 **Michaël Zasso** <targos@protonmail.com> (he/him)
 * [tniessen](https://github.com/tniessen) -
@@ -226,6 +224,8 @@ For information about the governance of the Node.js project, see
 **Bert Belder** <bertbelder@gmail.com>
 * [rvagg](https://github.com/rvagg) -
 **Rod Vagg** <r@va.gg>
+* [sam-github](https://github.com/sam-github) -
+**Sam Roberts** <vieuxtech@gmail.com>
 * [shigeki](https://github.com/shigeki) -
 **Shigeki Ohtsu** <ohtsu@ohtsu.org> (he/him)
 * [thefourtheye](https://github.com/thefourtheye) -
@@ -277,14 +277,14 @@ For information about the governance of the Node.js project, see
 **Shelley Vohr** <codebytere@gmail.com> (she/her)
 * [danbev](https://github.com/danbev) -
 **Daniel Bevenius** <daniel.bevenius@gmail.com> (he/him)
+* [danielleadams](https://github.com/danielleadams) -
+**Danielle Adams** <adamzdanielle@gmail.com> (she/her)
 * [davisjam](https://github.com/davisjam) -
 **Jamie Davis** <davisjam@vt.edu> (he/him)
 * [devnexen](https://github.com/devnexen) -
 **David Carlier** <devnexen@gmail.com>
 * [devsnek](https://github.com/devsnek) -
 **Gus Caplan** <me@gus.host> (he/him)
-* [digitalinfinity](https://github.com/digitalinfinity) -
-**Hitesh Kanwathirtha** <digitalinfinity@gmail.com> (he/him)
 * [edsadr](https://github.com/edsadr) -
 **Adrian Estrada** <edsadr@gmail.com> (he/him)
 * [eugeneo](https://github.com/eugeneo) -
@@ -307,8 +307,6 @@ For information about the governance of the Node.js project, see
 **Jiawen Geng** <technicalcute@gmail.com>
 * [GeoffreyBooth](https://github.com/geoffreybooth) -
 **Geoffrey Booth** <webmaster@geoffreybooth.com> (he/him)
-* [gibfahn](https://github.com/gibfahn) -
-**Gibson Fahnestock** <gibfahn@gmail.com> (he/him)
 * [gireeshpunathil](https://github.com/gireeshpunathil) -
 **Gireesh Punathil** <gpunathi@in.ibm.com> (he/him)
 * [guybedford](https://github.com/guybedford) -
@@ -337,8 +335,6 @@ For information about the governance of the Node.js project, see
 **Juan José Arboleda** <soyjuanarbol@gmail.com> (he/him)
 * [JungMinu](https://github.com/JungMinu) -
 **Minwoo Jung** <nodecorelab@gmail.com> (he/him)
-* [kfarnung](https://github.com/kfarnung) -
-**Kyle Farnung** <kfarnung@microsoft.com> (he/him)
 * [lance](https://github.com/lance) -
 **Lance Ball** <lball@redhat.com> (he/him)
 * [legendecas](https://github.com/legendecas) -
@@ -385,18 +381,16 @@ For information about the governance of the Node.js project, see
 **Ron Korving** <ron@ronkorving.nl>
 * [rubys](https://github.com/rubys) -
 **Sam Ruby** <rubys@intertwingly.net>
+* [ruyadorno](https://github.com/ruyadorno) -
+**Ruy Adorno** <ruyadorno@github.com> (he/him)
 * [rvagg](https://github.com/rvagg) -
 **Rod Vagg** <rod@vagg.org>
 * [ryzokuken](https://github.com/ryzokuken) -
 **Ujjwal Sharma** <ryzokuken@disroot.org> (he/him)
 * [saghul](https://github.com/saghul) -
 **Saúl Ibarra Corretgé** <saghul@gmail.com>
-* [sam-github](https://github.com/sam-github) -
-**Sam Roberts** <vieuxtech@gmail.com>
 * [santigimeno](https://github.com/santigimeno) -
 **Santiago Gimeno** <santiago.gimeno@gmail.com>
-* [sebdeckers](https://github.com/sebdeckers) -
-**Sebastiaan Deckers** <sebdeckers83@gmail.com>
 * [seishun](https://github.com/seishun) -
 **Nikolai Vavilov** <vvnicholas@gmail.com>
 * [shigeki](https://github.com/shigeki) -
@@ -409,6 +403,8 @@ For information about the governance of the Node.js project, see
 **Steven R Loomis** <srloomis@us.ibm.com>
 * [starkwang](https://github.com/starkwang) -
 **Weijia Wang** <starkwang@126.com>
+* [sxa](https://github.com/sxa) -
+**Stewart X Addison** <sxa@uk.ibm.com>
 * [targos](https://github.com/targos) -
 **Michaël Zasso** <targos@protonmail.com> (he/him)
 * [thefourtheye](https://github.com/thefourtheye) -
@@ -456,12 +452,16 @@ For information about the governance of the Node.js project, see
 **Claudio Rodriguez** <cjrodr@yahoo.com>
 * [DavidCai1993](https://github.com/DavidCai1993) -
 **David Cai** <davidcai1993@yahoo.com> (he/him)
+* [digitalinfinity](https://github.com/digitalinfinity) -
+**Hitesh Kanwathirtha** <digitalinfinity@gmail.com> (he/him)
 * [eljefedelrodeodeljefe](https://github.com/eljefedelrodeodeljefe) -
 **Robert Jefe Lindstaedt** <robert.lindstaedt@gmail.com>
 * [estliberitas](https://github.com/estliberitas) -
 **Alexander Makarenko** <estliberitas@gmail.com>
 * [firedfox](https://github.com/firedfox) -
 **Daniel Wang** <wangyang0123@gmail.com>
+* [gibfahn](https://github.com/gibfahn) -
+**Gibson Fahnestock** <gibfahn@gmail.com> (he/him)
 * [glentiki](https://github.com/glentiki) -
 **Glen Keane** <glenkeane.94@gmail.com> (he/him)
 * [iarna](https://github.com/iarna) -
@@ -484,6 +484,8 @@ For information about the governance of the Node.js project, see
 **Josh Gavant** <josh.gavant@outlook.com>
 * [julianduque](https://github.com/julianduque) -
 **Julian Duque** <julianduquej@gmail.com> (he/him)
+* [kfarnung](https://github.com/kfarnung) -
+**Kyle Farnung** <kfarnung@microsoft.com> (he/him)
 * [kunalspathak](https://github.com/kunalspathak) -
 **Kunal Pathak** <kunal.pathak@microsoft.com>
 * [lucamaraschi](https://github.com/lucamaraschi) -
@@ -530,6 +532,10 @@ For information about the governance of the Node.js project, see
 **Roman Klauke** <romaaan.git@gmail.com>
 * [RReverser](https://github.com/RReverser) -
 **Ingvar Stepanyan** <me@rreverser.com>
+* [sam-github](https://github.com/sam-github) -
+**Sam Roberts** <vieuxtech@gmail.com>
+* [sebdeckers](https://github.com/sebdeckers) -
+**Sebastiaan Deckers** <sebdeckers83@gmail.com>
 * [stefanmb](https://github.com/stefanmb) -
 **Stefan Budeanu** <stefan@budeanu.com>
 * [tellnes](https://github.com/tellnes) -

benchmark/policy/policy-startup.js

@@ -0,0 +1,51 @@
+// Tests the impact on eager operations required for policies affecting
+// general startup,  does not test lazy operations
+'use strict';
+const common = require('../common.js');
+
+const configs = {
+  n: [1024]
+};
+
+const options = {
+  flags: ['--expose-internals']
+};
+
+const bench = common.createBenchmark(main, configs, options);
+
+function main(conf) {
+  const hash = (str, algo) => {
+    const hash = require('crypto').createHash(algo);
+    return hash.update(str).digest('base64');
+  };
+  const resources = Object.fromEntries(
+    // Simulate graph of 1k modules
+    Array.from({ length: 1024 }, (_, i) => {
+      return [`./_${i}`, {
+        integrity: `sha256-${hash(`// ./_${i}`, 'sha256')}`,
+        dependencies: Object.fromEntries(Array.from({
+          // Average 3 deps per 4 modules
+          length: Math.floor((i % 4) / 2)
+        }, (_, ii) => {
+          return [`_${ii}`, `./_${i - ii}`];
+        })),
+      }];
+    })
+  );
+  const json = JSON.parse(JSON.stringify({ resources }), (_, o) => {
+    if (o && typeof o === 'object') {
+      Reflect.setPrototypeOf(o, null);
+      Object.freeze(o);
+    }
+    return o;
+  });
+  const { Manifest } = require('internal/policy/manifest');
+
+  bench.start();
+
+  for (let i = 0; i < conf.n; i++) {
+    new Manifest(json, 'file://benchmark/policy-relative');
+  }
+
+  bench.end(conf.n);
+}

common.gypi

@@ -36,7 +36,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.23',
+    'v8_embedder_string': '-node.12',
 
     ##### V8 defaults for Node.js #####
 

deps/npm/AUTHORS

@@ -695,3 +695,7 @@ Jarda Snajdr <jsnajdr@gmail.com>
 Naix Geng <1308363651@qq.com>
 Dylan Treisman <dylanzt@gmail.com>
 mum-never-proud <abhuz@hotmail.com>
+Peter Fich <peterfich@users.noreply.github.com>
+Maxwell Gerber <mgerber@berkeley.edu>
+Sean Poulter <sean.poulter@gmail.com>
+vanishcode <vanishcode@outlook.com>

deps/npm/CHANGELOG.md

@@ -1,3 +1,25 @@
+## 6.14.6 (2020-07-07)
+
+### BUG FIXES
+* [`a9857b8f6`](https://github.com/npm/cli/commit/a9857b8f6869451ff058789c4631fadfde5bbcbc) chore: remove auth info from logs ([@claudiahdz](https://github.com/claudiahdz))
+* [`b7ad77598`](https://github.com/npm/cli/commit/b7ad77598112908d60195d0fbc472b3c84275fd5) [#1416](https://github.com/npm/cli/pull/1416) fix: wrong `npm doctor` command result ([@vanishcode](https://github.com/vanishcode))
+
+### DEPENDENCIES
+* [`94eca6377`](https://github.com/npm/cli/commit/94eca637756376b949edfb697e179a1fdcc231ee) `npm-registry-fetch@4.0.5` ([@claudiahdz](https://github.com/claudiahdz))
+* [`c49b6ae28`](https://github.com/npm/cli/commit/c49b6ae28791ff7184288be16654f97168aa9705) [#1418](https://github.com/npm/cli/pull/1418) `spdx-license-ids@3.0.5` ([@kemitchell](https://github.com/kemitchell))
+
+### DOCUMENTATION
+* [`2e052984b`](https://github.com/npm/cli/commit/2e052984b08c09115ed75387fb2c961631d85d77)
+  [#1459](https://github.com/npm/cli/pull/1459)
+  chore(docs): fixed links to cli commands ([@claudiahdz](https://github.com/claudiahdz))
+* [`0ca3509ca`](https://github.com/npm/cli/commit/0ca3509ca940865392daeeabb39192f7d5af9f5e)
+  [#1283](https://github.com/npm/cli/pull/1283) Update npm-link.md ([@peterfich](https://github.com/peterfich))
+* [`3dd429e9a`](https://github.com/npm/cli/commit/3dd429e9aad760ce2ff9e522b34ebfebd85b460c)
+  [#1377](https://github.com/npm/cli/pull/1377)
+  Add note about dropped `*` filenames ([@maxwellgerber](https://github.com/maxwellgerber))
+* [`9a2e2e797`](https://github.com/npm/cli/commit/9a2e2e797e5c91e7f4f261583a1906e2c440cc2f)
+  [#1429](https://github.com/npm/cli/pull/1429) Fix typo ([@seanpoulter](https://github.com/seanpoulter))
+
 ## 6.14.5 (2020-05-01)
 
 ### BUG FIXES

deps/npm/bin/npm-cli.js

@@ -28,6 +28,7 @@
   var npm = require('../lib/npm.js')
   var npmconf = require('../lib/config/core.js')
   var errorHandler = require('../lib/utils/error-handler.js')
+  var replaceInfo = require('../lib/utils/replace-info.js')
 
   var configDefs = npmconf.defs
   var shorthands = configDefs.shorthands
@@ -40,7 +41,8 @@
     process.argv.splice(1, 1, 'npm', '-g')
   }
 
-  log.verbose('cli', process.argv)
+  var args = replaceInfo(process.argv)
+  log.verbose('cli', args)
 
   var conf = nopt(types, shorthands)
   npm.argv = conf.argv.remain