Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update ESLint to 7.5.0 #34423

Closed
wants to merge 1 commit into from
Closed

tools: update ESLint to 7.5.0 #34423

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 18, 2020

Update ESLint to 7.5.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 7.5.0
311a295 
Update ESLint to 7.5.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 18, 2020
Trott
Trott approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ye Olde Rubber Stamp LGTM

trivikr
trivikr approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott
Copy link
Member

Trott commented Jul 21, 2020

Landed in 2c05bee

@Trott Trott closed this Jul 21, 2020
Trott pushed a commit that referenced this pull request Jul 21, 2020
@cjihrig @Trott
tools: update ESLint to 7.5.0
2c05bee 
Update ESLint to 7.5.0

PR-URL: #34423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@cjihrig cjihrig deleted the eslint branch July 21, 2020 13:30
cjihrig added a commit that referenced this pull request Jul 23, 2020
@cjihrig
tools: update ESLint to 7.5.0
0957a84 
Update ESLint to 7.5.0

PR-URL: #34423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@cjihrig @MylesBorins
tools: update ESLint to 7.5.0
f4d61c7 
Update ESLint to 7.5.0

PR-URL: #34423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@cjihrig @addaleax
tools: update ESLint to 7.5.0
f64b565 
Update ESLint to 7.5.0

PR-URL: #34423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@cjihrig @addaleax
tools: update ESLint to 7.5.0
aa15abb 
Update ESLint to 7.5.0

PR-URL: #34423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @Trott @targos @trivikr @nodejs-github-bot