Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: do not run benchmark tests on 'make test' #34434

Merged
merged 8 commits into from
Jul 22, 2020
Merged

build: do not run benchmark tests on 'make test' #34434

merged 8 commits into from
Jul 22, 2020

Commits on Jul 22, 2020

  1. test: fix flaky test-watch-file 

    PR-URL: nodejs#34420
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @Trott
    Trott committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    b0b52b2 View commit details
    Browse the repository at this point in the history

  2. zlib: switch to lazy init for zlib streams 

    PR-URL: nodejs#34048
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @puzpuzpuz
    puzpuzpuz committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    f8eaeb0 View commit details
    Browse the repository at this point in the history

  3. doc: add HarshithaKP to collaborators 

    Fixes: nodejs#34242

PR-URL: nodejs#34417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
    @HarshithaKP
    HarshithaKP committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    07b3aae View commit details
    Browse the repository at this point in the history

  4. build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot 

    Otherwise the build would fail with
`./configure --experimental-quic --ninja` as the list of per-Environment
values would not match and the code cache builder would not generate
code cache for the quic JS sources. This is more or less a band-aid -
a proper fix would be to aggregate these flags into something
that can be included by all these different binary targets.
See nodejs#31074.

PR-URL: nodejs#34454
Fixes: nodejs#34435
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    @joyeecheung @gengjiawen
    joyeecheung authored and gengjiawen committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    f4f191b View commit details
    Browse the repository at this point in the history

  5. worker: set trackUnmanagedFds to true by default 

    This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through `fs.open()`.

Refs: nodejs#34303

PR-URL: nodejs#34394
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @addaleax @jasnell
    addaleax authored and jasnell committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7603c7e View commit details
    Browse the repository at this point in the history

  6. doc: add author-ready label ref to onboarding doc 

    The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.

PR-URL: nodejs#34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
    @ruyadorno @MylesBorins
    ruyadorno authored and MylesBorins committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    bfef588 View commit details
    Browse the repository at this point in the history

  7. 2020-07-22, Version 12.18.3 'Erbium' (LTS) 

    Notable changes:

deps:
  * upgrade npm to 6.14.6 (claudiahdz) [nodejs#34246](nodejs#34246)
  * update node-inspect to v2.0.0 (Jan Krems) [nodejs#33447](nodejs#33447)
  * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [nodejs#33521](nodejs#33521)

PR-URL: nodejs#34343
    @codebytere
    codebytere committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    90ee98a View commit details
    Browse the repository at this point in the history

  8. build: do not run benchmark tests on 'make test' 

    Fixes: nodejs#34427

PR-URL: nodejs#34434
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott
    Trott committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    3caa2e2 View commit details
    Browse the repository at this point in the history