Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: delete invalid test #34445

Closed
wants to merge 1 commit into from
Closed

test: delete invalid test #34445

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: #34057

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
test: delete invalid test
4f708cd 
This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: nodejs#34057
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 20, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32427/

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Jul 21, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2020 •
edited by addaleax
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/32447/ (:green_heart:)

@addaleax
Copy link
Member Author

Landed in 06765d8

addaleax added a commit that referenced this pull request Jul 22, 2020
@addaleax
test: delete invalid test
06765d8 
This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: #34057

PR-URL: #34445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax closed this Jul 22, 2020
@addaleax addaleax deleted the invalid-test branch July 22, 2020 20:54
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@addaleax @MylesBorins
test: delete invalid test
1a9138d 
This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: #34057

PR-URL: #34445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: delete invalid test
d02eed3 
This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: #34057

PR-URL: #34445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: delete invalid test
4d4aa9a 
This test has not been working correctly since at least a555be2.

Since it tests internals, any replacement test might become invalid
in a similar way.

Refs: #34057

PR-URL: #34445
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @jasnell @Trott