[v12.x backport] Forces Powershell to use tls1.2 #34462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
install
codebytere
force-pushed
the
v12.x-staging
branch
from
b64963e to
3b1d9b3
Compare
This was referenced Jul 22, 2020
|
@bzoz looks like this needs a rebase, tried to do it myself but it would let me push to the branch |
|
This has not yet gone out in a current release, so we need to wait a bit to backport to 12 |
bzoz
force-pushed
the
backport-v12-33609
branch
from
4eab9c8 to
a3a4e44
Compare
|
Rebased |
BethGriggs
force-pushed
the
v12.x-staging
branch
from
729799d to
c9bd1a7
Compare
addaleax
force-pushed
the
v12.x-staging
branch
4 times, most recently
from
55fe022 to
65b7bf4
Compare
|
@bzoz Sorry to ask, but could you rebase again? |
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: nodejs#33140 PR-URL: nodejs#33609 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bzoz
force-pushed
the
backport-v12-33609
branch
from
a3a4e44 to
a5282dd
Compare
|
@addaleax done! |
github-actions
bot
removed
the
request-ci
addaleax
pushed a commit
that referenced
this pull request
Sep 23, 2020
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: #33140 PR-URL: #33609 Backport-PR-URL: #34462 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in 27ceec0 (I left the commit message as-is, to be consistent with the decision for v14.x: #34461 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.
Fixes: #33140
PR-URL: #33609
Reviewed-By: Bartosz Sosnowski bartosz@janeasystems.com
Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com
Reviewed-By: Tobias Nießen tniessen@tnie.de
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes