Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: don't run Actions on non-master pushes #34464

Closed
wants to merge 1 commit into from
Closed

ci: don't run Actions on non-master pushes #34464

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

This PR cleans up duplicate workflow runs for PRs by making it such that workflows are triggered on push only for the master branch. Not all PRs target master, so we still want to trigger workflows on all PRs targeting any branch for the pull_request event.

cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 21, 2020
MylesBorins
MylesBorins approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

fast track?

@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 21, 2020
@addaleax
Copy link
Member

Landed in 3f455cb

addaleax pushed a commit that referenced this pull request Jul 21, 2020
@codebytere @addaleax
build: don't run Actions on non-master pushes
3f455cb 
PR-URL: #34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@addaleax addaleax closed this Jul 21, 2020
@codebytere codebytere deleted the more-specific-actions-triggers branch July 21, 2020 19:06
cjihrig pushed a commit that referenced this pull request Jul 23, 2020
@codebytere @cjihrig
build: don't run Actions on non-master pushes
009972c 
PR-URL: #34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@richardlau richardlau mentioned this pull request Jul 24, 2020
Closed
2 tasks
gengjiawen pushed a commit that referenced this pull request Jul 27, 2020
@richardlau @gengjiawen
build: don't run test-asan workflow on non-master pushes
b2c08f2 
PR-URL: #34509
Refs: #34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@codebytere @MylesBorins
build: don't run Actions on non-master pushes
3fda3d4 
PR-URL: #34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 27, 2020
@richardlau @MylesBorins
build: don't run test-asan workflow on non-master pushes
cce1f3e 
PR-URL: #34509
Refs: #34464
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
Merged
@mhdawson mhdawson mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @MylesBorins @addaleax @richardlau @nodejs-github-bot