Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: absorb path error cases #34519

Closed
wants to merge 0 commits into from
Closed

lib: absorb path error cases #34519

wants to merge 0 commits into from

Conversation

gireeshpunathil
Copy link
Member

Catch low level libuv failure and
rethrow with a more meaningful message

Adjust the test to cover a possible failure scenario

Fixes: #33759
Refs: #33759 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

addaleax
addaleax requested changes Jul 26, 2020
View reviewed changes
lib/internal/bootstrap/pre_execution.js Outdated Show resolved Hide resolved
@gireeshpunathil gireeshpunathil force-pushed the try-guard-process-argv branch from f9d01ed to 79857e1 Compare July 26, 2020 15:25
@gireeshpunathil gireeshpunathil changed the title lib, test: harden path error cases lib: absorb path error cases Jul 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32510/

BridgeAR
BridgeAR reviewed Jul 27, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test case for this?

@gireeshpunathil
Copy link
Member Author

I have thought about it, but looks like it is difficult:

  • the path resolution of the executable cannot be mimic'd to fail in a JS test
  • the resource constraints cannot be confined exactly to this API. If at all, the referenced test case's assertion is going to cover that.

let me know if you have any any suggestions!

gireeshpunathil added a commit that referenced this pull request Jul 30, 2020
@gireeshpunathil
lib: absorb path error cases
4692e28 
Absorb low level libuv failure in
the process initialization phase

Fixes: #33759
Refs: #33759 (comment)
PR-URL: #34519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@gireeshpunathil gireeshpunathil force-pushed the try-guard-process-argv branch from 79857e1 to 4692e28 Compare July 30, 2020 08:18
@gireeshpunathil
Copy link
Member Author

landed in 4692e28

codebytere pushed a commit that referenced this pull request Aug 5, 2020
@gireeshpunathil @codebytere
lib: absorb path error cases
335cb0d 
Absorb low level libuv failure in
the process initialization phase

Fixes: #33759
Refs: #33759 (comment)
PR-URL: #34519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
codebytere added a commit to electron/electron that referenced this pull request Sep 1, 2020
@codebytere
Fixup context-aware nnm patch
c836b74 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 2, 2020
@codebytere
Fixup context-aware nnm patch
64e2940 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 4, 2020
@codebytere
Fixup context-aware nnm patch
5abe2c2 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 14, 2020
@codebytere
Fixup context-aware nnm patch
a8c5bde 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 14, 2020
@codebytere
Fixup context-aware nnm patch
154a46e 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 14, 2020
@codebytere
Fixup context-aware nnm patch
b73e2fe 
nodejs/node#34519
codebytere added a commit to electron/electron that referenced this pull request Sep 16, 2020
@codebytere
Fixup context-aware nnm patch
4cda31e 
nodejs/node#34519
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
lib: absorb path error cases
8505bfe 
Absorb low level libuv failure in
the process initialization phase

Fixes: #33759
Refs: #33759 (comment)
PR-URL: #34519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@gireeshpunathil @addaleax
lib: absorb path error cases
633b4d5 
Absorb low level libuv failure in
the process initialization phase

Fixes: #33759
Refs: #33759 (comment)
PR-URL: #34519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@mscdex mscdex mscdex left review comments

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@himself65 himself65 himself65 approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-worker-init-failure
9 participants
@gireeshpunathil @nodejs-github-bot @mscdex @jasnell @addaleax @lpinca @BridgeAR @himself65 @HarshithaKP