[v12.x backport] module: deprecate module.parent #34592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Aug 1, 2020
mscdex
reviewed
Aug 1, 2020
aduh95
force-pushed
the
backport-32217-to-erbium
branch
from
c57de5a to
6570100
Compare
|
@MylesBorins can you please review this? |
|
I'm unsure if we have prior art in backporting a doc only deprecation. @jasnell @nodejs/tsc thoughts? |
|
I think it's fine to backport a doc only deprecation if the suggested alternative is available. |
3 tasks
|
If this deprecation was docs only I think I would be less concerned about it. The fact that it makes changes to internals, even if not observable, has me pausing. |
|
@MylesBorins do you want me to rework the PR to include only doc changes? |
This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: nodejs/modules#469 PR-URL: nodejs#32217 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
aduh95
force-pushed
the
backport-32217-to-erbium
branch
from
6570100 to
573ad3e
Compare
BethGriggs
approved these changes
Aug 18, 2020
richardlau
approved these changes
Aug 18, 2020
ruyadorno
approved these changes
Aug 18, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Aug 18, 2020
This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: nodejs/modules#469 PR-URL: #32217 Backport-PR-URL: #34592 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 729799d |
BethGriggs
added
the
notable-change
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature does not work when a module is imported using ECMAScript
modules specification, therefore it is deprecated.
As of v12.17.0, ESM is unflagged for Node.js v12; IMHO it makes sense to backport the doc deprecation.
v14 Backport-PR-URL: #33533
PR-URL: #32217
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes