Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add tests for validateNumber/validateString #34672

Closed
wants to merge 1 commit into from
Closed

test: add tests for validateNumber/validateString #34672

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs/testing

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 7, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32679/

This was referenced Aug 8, 2020
Open
Open
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32683/

This was referenced Aug 9, 2020
Open
Open
Trott pushed a commit that referenced this pull request Aug 9, 2020
@lundibundi @Trott
test: add tests for validateNumber/validateString
6914b37 
PR-URL: #34672
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 9, 2020

Landed in 6914b37

@Trott Trott closed this Aug 9, 2020
This was referenced Aug 10, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@lundibundi @MylesBorins
test: add tests for validateNumber/validateString
924c69c 
PR-URL: #34672
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@lundibundi @BethGriggs
test: add tests for validateNumber/validateString
093a4b0 
PR-URL: #34672
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@rickyes rickyes rickyes approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@rexagod rexagod rexagod approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lundibundi @nodejs-github-bot @Trott @jasnell @lpinca @rickyes @ZYSzys @rexagod