-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: runtime deprecate legacy api #34914
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
the
url
Issues and PRs related to the legacy built-in url module.
label
Aug 24, 2020
jasnell
added
deprecations
Issues and PRs related to deprecations.
semver-major
PRs that contain breaking changes and should be released in the next major version.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 24, 2020
jasnell
changed the title
url: runtime deprecation legacy api
url: runtime deprecate legacy api
Aug 24, 2020
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 24, 2020
11 tasks
I think this will create a lot of unnecessary "panic" in user land. |
I'm a fan of this but this is probably going to warn on every bit of code ever written, we might need to filter out node_modules like the buffer runtime deprecation. |
richardlau
added
the
notable-change
PRs with changes that should be highlighted in changelogs.
label
Aug 25, 2020
Another problem is that it is not trivial to migrate to
|
Ok. Will close this for now and revisit later. |
9 tasks
2 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
notable-change
PRs with changes that should be highlighted in changelogs.
semver-major
PRs that contain breaking changes and should be released in the next major version.
url
Issues and PRs related to the legacy built-in url module.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a bit controversial. The legacy
url.parse()
/url.format()
/url.resolve()
API has been runtime deprecated for a few years now and developers really should be using theURL
object instead. It's time we elevated to a runtime deprecation to more actively discourage use of the old API.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes