Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: replace require() with reference links in http2.md #34956

Merged
merged 1 commit into from
Aug 30, 2020
Merged

doc: replace require() with reference links in http2.md #34956

merged 1 commit into from
Aug 30, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 28, 2020

Refs: #34929 (comment)

Checklist

@Trott Trott requested review from a team as code owners August 28, 2020 14:55
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 28, 2020
@Trott Trott mentioned this pull request Aug 28, 2020
Merged
2 tasks
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2020
@Trott
doc: replace require() with reference links in http2.md
07e7ad9 
Refs: nodejs#34929 (comment)

PR-URL: nodejs#34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@Trott Trott merged commit 07e7ad9 into nodejs:master Aug 30, 2020
@Trott
Copy link
Member Author

Trott commented Aug 30, 2020

Landed in 07e7ad9

@Trott Trott deleted the reference-link branch August 30, 2020 15:37
richardlau pushed a commit that referenced this pull request Sep 1, 2020
@Trott @richardlau
doc: replace require() with reference links in http2.md
94c6e09 
Refs: #34929 (comment)

PR-URL: #34956
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyes rickyes rickyes approved these changes

@lundibundi lundibundi lundibundi approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @addaleax @benjamingr @lpinca @lundibundi @rickyes