Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove incorrect debug() in test-policy-integrity #34961

Merged
merged 1 commit into from
Sep 2, 2020
Merged

test: remove incorrect debug() in test-policy-integrity #34961

merged 1 commit into from
Sep 2, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 28, 2020

The instructions to use test:policy-integrity:NUMBER do not work, I'm
afraid. This removes them.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott requested a review from bmeck August 28, 2020 21:56
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2020
@Trott
Copy link
Member Author

Trott commented Aug 28, 2020

/ping @bmeck, just in case I got it wrong here, but I don't think I did?

@Trott
Copy link
Member Author

Trott commented Aug 28, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16175/

@Trott Trott added the review wanted PRs that need reviews. label Aug 30, 2020
@Trott
Copy link
Member Author

Trott commented Sep 1, 2020

@nodejs/collaborators This could use some reviews.

ryzokuken
ryzokuken approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@puzpuzpuz puzpuzpuz self-requested a review September 1, 2020 06:49
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed review wanted PRs that need reviews. labels Sep 1, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@richardlau
Copy link
Member

Commit subsystem should be "test" instead of "doc".

@Trott Trott changed the title doc: remove incorrect debug() in test-policy-integrity test: remove incorrect debug() in test-policy-integrity Sep 1, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32995/

@Trott
Copy link
Member Author

Trott commented Sep 2, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16218/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32999/

@Trott
test: remove incorrect debug() in test-policy-integrity
4f7440c 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott merged commit 4f7440c into nodejs:master Sep 2, 2020
@Trott
Copy link
Member Author

Trott commented Sep 2, 2020

Landed in 4f7440c

@Trott Trott deleted the policy-integrity branch September 2, 2020 13:56
richardlau pushed a commit that referenced this pull request Sep 2, 2020
@Trott @richardlau
test: remove incorrect debug() in test-policy-integrity
12115e1 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@richardlau richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 3, 2020
@Trott @richardlau
test: remove incorrect debug() in test-policy-integrity
b698d2e 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove incorrect debug() in test-policy-integrity
c2a3314 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: remove incorrect debug() in test-policy-integrity
0bd1768 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: #34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
test: remove incorrect debug() in test-policy-integrity
2ef967b 
The instructions to use `test:policy-integrity:NUMBER` do not work, I'm
afraid. This removes them.

PR-URL: nodejs#34961
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

@trivikr trivikr trivikr approved these changes

@himself65 himself65 himself65 approved these changes

@ryzokuken ryzokuken ryzokuken approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@bmeck bmeck bmeck approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @richardlau @bmeck @targos @ryzokuken @himself65 @trivikr @puzpuzpuz