lib: return boolean result of assert.match method

[juanarbol]

The assert.match method by default will throws if there is no match,
this change can add the function of instead of throwing or not, returns
the boolean result of match.

Fixes: #33869

Note: I'm going to leave the documentation as a TODO :)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

I think this effectively just gives you the same result as regexp.test(string), as it is currently implemented, and in that case regexp.test(string) should definitely be preferred, I think.

I would suggest either closing #33869 as wontfix – I agree with the concern voiced by the author that this would be unexpected for an assertion method – or following @lundibundi’s suggestion there and making all the underlying assertion mechanisms available as separate methods, not just assert.match

[juanarbol]

I think this effectively just gives you the same result as regexp.test(string), as it is currently implemented, and in that case regexp.test(string) should definitely be preferred, I think.

:O haha, this is true...

I would suggest either closing #33869 as wontfix – I agree with the concern voiced by the author that this would be unexpected for an assertion method – or following @lundibundi’s suggestion there and making all the underlying assertion mechanisms available as separate methods, not just assert.match

That really make sense to my.

[juanarbol]

Closing this, this is almost like regexp.test(string).