Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update example url of ICU #35373

Merged
merged 1 commit into from
Sep 30, 2020
Merged

doc: update example url of ICU #35373

merged 1 commit into from
Sep 30, 2020

Conversation

watilde
Copy link
Member

@watilde watilde commented Sep 27, 2020

The host page of ICU package which is written as http://download.icu-project.org/files/icu4c/58.1/icu4c-58_1-src.tgz in the guide does not seem to available and they move to GitHub's release page for downloads. Refs http://site.icu-project.org/download/67#TOC-ICU4C-Download as an example. As a minor tweak, I also updated the version number of V8_MINIMUM_ICU_VERSION in the doc to sync with the actual code in deps/v8/src/objects/intl-objects.h.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@watilde watilde added the doc Issues and PRs related to the documentations. label Sep 27, 2020
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo (exmaple) in the commit message title but otherwise LGTM.

@watilde watilde changed the title doc: update exmaple url of ICU doc: update example url of ICU Sep 30, 2020
PR-URL: nodejs#35373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Sep 30, 2020

Landed in d8ec5a2

@Trott Trott merged commit d8ec5a2 into nodejs:master Sep 30, 2020
@watilde watilde deleted the docs/icu branch September 30, 2020 13:28
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
PR-URL: #35373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
PR-URL: nodejs#35373
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants