doc: specify how to detect EOF #35445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
jasnell
approved these changes
Oct 1, 2020
gireeshpunathil
approved these changes
Oct 1, 2020
github-actions
bot
removed
the
request-ci
addaleax
reviewed
Oct 2, 2020
lpinca
force-pushed
the
fix/issue-35363
branch
from
95b71d5
to
1f89ae6
Compare
addaleax
approved these changes
Oct 2, 2020
Trott
approved these changes
Oct 2, 2020
cjihrig
approved these changes
Oct 2, 2020
himself65
approved these changes
Oct 3, 2020
puzpuzpuz
approved these changes
Oct 3, 2020
Specify how to detect end-of-file when using `fs.read()` and `filehandle.read()`. PR-URL: nodejs#35445 Fixes: nodejs#35363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
lpinca
force-pushed
the
fix/issue-35363
branch
from
1f89ae6
to
0f9170e
Compare
|
Landed in 0f9170e. |
danielleadams
pushed a commit
that referenced
this pull request
Oct 6, 2020
Specify how to detect end-of-file when using `fs.read()` and `filehandle.read()`. PR-URL: #35445 Fixes: #35363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Specify how to detect end-of-file when using `fs.read()` and `filehandle.read()`. PR-URL: nodejs#35445 Fixes: nodejs#35363 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify how to detect end-of-file when using
fs.read()andfilehandle.read().Fixes: #35363
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes